Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/consensus/tendermint: Don't use UnsafeSigner #2670

Merged
merged 1 commit into from
Feb 12, 2020

Conversation

Yawning
Copy link
Contributor

@Yawning Yawning commented Feb 12, 2020

No, that's German for "The UnsafeSigner, The"

@Yawning Yawning added the c:consensus/tendermint Category: Tendermint-based consensus label Feb 12, 2020
@Yawning Yawning self-assigned this Feb 12, 2020
@Yawning Yawning force-pushed the yawning/feature/die-unsafesigner-die branch from 9c7da44 to f258c3c Compare February 12, 2020 14:54
@codecov
Copy link

codecov bot commented Feb 12, 2020

Codecov Report

Merging #2670 into master will increase coverage by 0.01%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2670      +/-   ##
==========================================
+ Coverage   63.06%   63.07%   +0.01%     
==========================================
  Files         365      365              
  Lines       34587    34586       -1     
==========================================
+ Hits        21812    21815       +3     
- Misses      10056    10060       +4     
+ Partials     2719     2711       -8
Impacted Files Coverage Δ
go/common/crypto/signature/signer.go 92.59% <ø> (ø) ⬆️
...ommon/crypto/signature/signers/file/file_signer.go 56.97% <ø> (-0.98%) ⬇️
go/consensus/tendermint/tendermint.go 65.46% <100%> (-2.13%) ⬇️
go/consensus/tendermint/seed.go 74.11% <100%> (+1.39%) ⬆️
go/consensus/tendermint/crypto/signature.go 81.81% <66.66%> (-18.19%) ⬇️
go/consensus/api/grpc.go 57.02% <0%> (-6.62%) ⬇️
go/common/grpc/proxy/proxy.go 58.87% <0%> (-5.61%) ⬇️
go/storage/metrics.go 73.21% <0%> (-2.68%) ⬇️
go/storage/mkvs/urkel/lookup.go 72.72% <0%> (-2.28%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97da2e6...a1ffc83. Read the comment docs.

@Yawning Yawning force-pushed the yawning/feature/die-unsafesigner-die branch from f258c3c to a1ffc83 Compare February 12, 2020 15:52
@Yawning Yawning marked this pull request as ready for review February 12, 2020 15:57
@Yawning Yawning merged commit aad6d64 into master Feb 12, 2020
@Yawning Yawning deleted the yawning/feature/die-unsafesigner-die branch February 12, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:consensus/tendermint Category: Tendermint-based consensus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants