Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a different CLI flag when specifying shares to reclaim from an escrow #2690

Closed
tjanez opened this issue Feb 18, 2020 · 0 comments · Fixed by #2738
Closed

Use a different CLI flag when specifying shares to reclaim from an escrow #2690

tjanez opened this issue Feb 18, 2020 · 0 comments · Fixed by #2738
Assignees
Labels
c:bug Category: bug c:cli Category: command line interface

Comments

@tjanez
Copy link
Member

tjanez commented Feb 18, 2020

SUMMARY

Currently, the oasis-node stake account gen_reclaim_escrow subcommand uses the --stake.amount flag for specifying the amount of shares to reclaim from an escrow:

https://github.com/oasislabs/oasis-core/blob/6ccac659d9bcf885dd2240c469bf5757ca19ee56/go/oasis-node/cmd/stake/account.go#L207

This is different from what one would expect by reading subcommand's --help:

https://github.com/oasislabs/oasis-core/blob/6ccac659d9bcf885dd2240c469bf5757ca19ee56/go/oasis-node/cmd/stake/account.go#L207

or reading the current version of the Operator docs:

We reclaim 3000 escrowed tokens by generating the reclaim escrow transaction:

oasis-node stake account gen_reclaim_escrow \
  ... trimmed ...
  --stake.transaction.amount 3000 \
  ... trimmed ...
ISSUE TYPE
  • Bug
ADDITIONAL INFORMATION

In the future, we might also add the ability to specify the amount of tokens (base units) to reclaim from an escrow and compute the number of shares automatically.

However, it is not possible to know how much the shares will be worth before the debonding period expires since any slashing could change shares' price.

@tjanez tjanez added c:bug Category: bug c:cli Category: command line interface labels Feb 18, 2020
@tjanez tjanez self-assigned this Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:bug Category: bug c:cli Category: command line interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant