buildkite: Add dynamic pipeline generator for conditional skipping #2702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjanez
requested review from
kostko,
peterjgilbert and
Yawning
as code owners
tjanez
force-pushed
the
tjanez/ci-improvements
branch
3 times, most recently
from
50a9bdd
to
4a66973
Compare
Codecov Report
@@ Coverage Diff @@
## master #2702 +/- ##
==========================================
+ Coverage 63.09% 63.20% +0.11%
==========================================
Files 377 377
Lines 35448 35448
==========================================
+ Hits 22365 22405 +40
+ Misses 10273 10240 -33
+ Partials 2810 2803 -7
Continue to review full report at Codecov.
|
kostko
reviewed
Feb 21, 2020
tjanez
force-pushed
the
tjanez/ci-improvements
branch
from
4a66973
to
308dd81
Compare
Use Buildkite's dynamic pipelines feature to dynamically choose between Code/Code-skip pipelines depending on whether the build was triggered for a pull request and the list of changes files.
tjanez
force-pushed
the
tjanez/ci-improvements
branch
from
308dd81
to
209b0a3
Compare
Yes, good catch. Done. |
kostko
approved these changes
Feb 21, 2020
pro-wh
reviewed
Feb 21, 2020
| # are no code-related changes compared to the pull request's base branch. | ||
| pr_and_no_code_related_changes() { | ||
| # Check if the build was triggered for a pull request. | ||
| if [[ -z $BUILDKITE_PULL_REQUEST_BASE_BRANCH ]]; then |
There was a problem hiding this comment.
can't skip in this case:
- we should build on master for PR merge commits, because there are steps that are set to run on master only
- you'd normally push a branch first and then open a PR for it. that first push wouldn't be built under this rule, because a PR doesn't exist yet
I'm afraid I don't understand. So, for non-pull-request builds, the full code pipeline will always be run. For an example, see the recent builds for the
Yes, as I announced internally, I needed to make a slight Buildkite triggering change:
This is needed since the dynamic Buildkite pipeline needs to know the base branch and changes from it to decide whether to run the full code pipeline or skip it. |
|
oh ok then thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Buildkite's dynamic pipelines feature to dynamically choose between Code/Code-skip pipelines depending on whether the build was triggered for a pull request and the list of changes files.
Closes #2573.