Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store consensus parameters for consensus backend itself #2710

Closed
kostko opened this issue Feb 24, 2020 · 0 comments · Fixed by #2674
Closed

Store consensus parameters for consensus backend itself #2710

kostko opened this issue Feb 24, 2020 · 0 comments · Fixed by #2674
Assignees
@kostko
Labels
c:breaking/consensus Category: breaking consensus changes c:consensus/tendermint Category: Tendermint-based consensus

Comments

@kostko
Copy link
Member

kostko commented Feb 24, 2020

We currently only store consensus parameters for the consensus backend itself (.Consensus.Parameters) in the genesis document. This doesn't allow for the option to change the consensus parameters later like we do for other mux apps where these parameters are stored under their own keys in ABCI state.

Consensus parameters should be moved under its own key in ABCI state to allow for future updates.
@kostko kostko added c:consensus/tendermint Category: Tendermint-based consensus c:breaking/consensus Category: breaking consensus changes labels Feb 24, 2020
@kostko kostko self-assigned this Feb 24, 2020
This was referenced Feb 24, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kostko kostko

Labels
c:breaking/consensus Category: breaking consensus changes c:consensus/tendermint Category: Tendermint-based consensus
Projects
None yet
Milestone
No milestone
1 participant
@kostko