Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/consensus/tendermint: Expire txes when CheckTx is disabled #2720

Merged
merged 1 commit into from
Feb 25, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Feb 25, 2020

When CheckTx is disabled (for debug purposes only, e.g. in E2E tests), we still
need to periodically remove old transactions as otherwise the mempool will fill
up. Keep track of transactions were added and invalidate them when they expire.

When CheckTx is disabled (for debug purposes only, e.g. in E2E tests), we still
need to periodically remove old transactions as otherwise the mempool will fill
up. Keep track of transactions were added and invalidate them when they expire.
@kostko kostko force-pushed the kostko/fix/checktx-debug-expiry branch from a39e50f to 7be9849 Compare February 25, 2020 09:22
@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #2720 into master will decrease coverage by 0.37%.
The diff coverage is 95.83%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2720      +/-   ##
=========================================
- Coverage   63.37%     63%   -0.38%     
=========================================
  Files         378     378              
  Lines       35515   35532      +17     
=========================================
- Hits        22509   22387     -122     
- Misses      10204   10316     +112     
- Partials     2802    2829      +27
Impacted Files Coverage Δ
go/consensus/tendermint/abci/mux.go 72.94% <95.83%> (+1.12%) ⬆️
go/consensus/tendermint/api/api.go 73.58% <0%> (-15.1%) ⬇️
go/worker/compute/executor/committee/state.go 74.07% <0%> (-11.12%) ⬇️
go/storage/metrics.go 72.64% <0%> (-7.7%) ⬇️
go/storage/api/root_cache.go 70.11% <0%> (-6.9%) ⬇️
go/worker/common/host/protocol/protocol.go 65.67% <0%> (-6.72%) ⬇️
go/consensus/tendermint/roothash/roothash.go 65.54% <0%> (-6%) ⬇️
go/common/grpc/auth/auth.go 88.88% <0%> (-5.56%) ⬇️
.../consensus/tendermint/apps/epochtime_mock/state.go 84.61% <0%> (-5.13%) ⬇️
go/worker/storage/service_external.go 47.31% <0%> (-4.31%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0536ab...7be9849. Read the comment docs.

@kostko kostko merged commit db3caef into master Feb 25, 2020
@kostko kostko deleted the kostko/fix/checktx-debug-expiry branch February 25, 2020 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants