Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose NodeByConsensusAddress via gRPC #2739

Closed
silentlight opened this issue Feb 27, 2020 · 2 comments
Closed

Expose NodeByConsensusAddress via gRPC #2739

silentlight opened this issue Feb 27, 2020 · 2 comments
Labels
c:client Category: client interface c:registry Category: entity/node/runtime registry service

Comments

@silentlight
Copy link

SUMMARY

Please expose https://github.com/oasislabs/oasis-core/blob/master/go/consensus/tendermint/apps/registry/state/state.go#L183 in the gRPC api

ISSUE TYPE
  • It is needed for getting a node information from validators endpoint
COMPONENT NAME

go/registry/api

ADDITIONAL INFORMATION
@kostko kostko added c:client Category: client interface c:registry Category: entity/node/runtime registry service labels Feb 27, 2020
@kostko
Copy link
Member

kostko commented Feb 28, 2020

An alternative is to make GetValidators return node identifiers or descriptors.

@Yawning Yawning mentioned this issue Mar 2, 2020
Merged
2 tasks
@Yawning
Copy link
Contributor

Yawning commented Mar 3, 2020

Implemented.

@Yawning Yawning closed this as completed Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c:client Category: client interface c:registry Category: entity/node/runtime registry service
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kostko @silentlight @Yawning