Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase scheduler max batch size #2741

Merged
merged 1 commit into from
Feb 27, 2020

Conversation

nhynes
Copy link
Contributor

@nhynes nhynes commented Feb 27, 2020

The value of 16M was taken from the the CLI flags

@nhynes nhynes force-pushed the nhynes/feature/increase-max-batch-sizee branch from 22fe63f to 044e40d Compare February 27, 2020 22:30
@codecov
Copy link

codecov bot commented Feb 27, 2020

Codecov Report

Merging #2741 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2741      +/-   ##
==========================================
- Coverage   62.99%   62.96%   -0.03%     
==========================================
  Files         383      383              
  Lines       36094    36094              
==========================================
- Hits        22737    22728       -9     
- Misses      10495    10500       +5     
- Partials     2862     2866       +4
Impacted Files Coverage Δ
go/worker/compute/executor/committee/state.go 74.07% <0%> (-25.93%) ⬇️
...ompute/txnscheduler/algorithm/batching/batching.go 78.66% <0%> (-6.67%) ⬇️
go/common/cbor/codec.go 64.7% <0%> (-5.89%) ⬇️
go/worker/compute/executor/committee/node.go 62% <0%> (-5.32%) ⬇️
.../consensus/tendermint/apps/epochtime_mock/state.go 84.61% <0%> (-5.13%) ⬇️
go/storage/metrics.go 75.21% <0%> (-5.13%) ⬇️
go/runtime/tagindexer/tagindexer.go 68.47% <0%> (-4.35%) ⬇️
go/consensus/tendermint/roothash/roothash.go 68.91% <0%> (-2.63%) ⬇️
go/worker/compute/merge/committee/node.go 75.37% <0%> (-2.49%) ⬇️
go/storage/client/client.go 76.47% <0%> (-2.11%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc3f2ff...044e40d. Read the comment docs.

@pro-wh
Copy link
Contributor

pro-wh commented Feb 27, 2020

@matevz, any argument for the current value of 1000?

@nhynes nhynes merged commit 207cb64 into master Feb 27, 2020
@nhynes nhynes deleted the nhynes/feature/increase-max-batch-sizee branch February 27, 2020 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants