Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove locked accounts #2753

Merged
merged 5 commits into from
Mar 6, 2020
Merged

Remove locked accounts #2753

merged 5 commits into from
Mar 6, 2020

Conversation

pro-wh
Copy link
Contributor

@pro-wh pro-wh commented Mar 5, 2020

We expect not to need this feature.

@pro-wh pro-wh requested a review from kostko March 5, 2020 00:21
@pro-wh pro-wh changed the title Revert #2627 Remove locked accounts Mar 5, 2020
Copy link
Contributor

@Yawning Yawning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this break a dump/restore cycle?

go/consensus/tendermint/apps/staking/transactions.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 5, 2020

Codecov Report

Merging #2753 into master will decrease coverage by 0.45%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2753      +/-   ##
==========================================
- Coverage   62.89%   62.43%   -0.46%     
==========================================
  Files         384      384              
  Lines       36258    36253       -5     
==========================================
- Hits        22804    22635     -169     
- Misses      10579    10761     +182     
+ Partials     2875     2857      -18     
Impacted Files Coverage Δ
...s-node/cmd/debug/txsource/workload/registration.go 0.00% <0.00%> (-74.44%) ⬇️
go/runtime/committee/committee.go 74.02% <0.00%> (-10.39%) ⬇️
...ompute/txnscheduler/algorithm/batching/batching.go 78.66% <0.00%> (-6.67%) ⬇️
go/common/cbor/codec.go 64.70% <0.00%> (-5.89%) ⬇️
...n/crypto/signature/signers/memory/memory_signer.go 71.42% <0.00%> (-4.77%) ⬇️
go/runtime/tagindexer/tagindexer.go 68.47% <0.00%> (-4.35%) ⬇️
go/worker/compute/txnscheduler/committee/node.go 60.18% <0.00%> (-4.02%) ⬇️
go/worker/common/p2p/p2p.go 67.56% <0.00%> (-3.61%) ⬇️
go/runtime/transaction/transaction.go 75.90% <0.00%> (-2.41%) ⬇️
go/worker/common/committee/group.go 80.32% <0.00%> (-1.32%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecf2102...0abce69. Read the comment docs.

@pro-wh
Copy link
Contributor Author

pro-wh commented Mar 5, 2020

locked accounts will become unlocked. unless we hooked up the parser to error out on unknown fields.

incidentally, we never saw any public network use this feature

@pro-wh pro-wh force-pushed the pro-wh/feature/lockdelete branch from e5947b5 to 0abce69 Compare March 5, 2020 19:22
@pro-wh pro-wh requested a review from Yawning March 5, 2020 20:36
@pro-wh pro-wh merged commit a7a65d7 into master Mar 6, 2020
@pro-wh pro-wh deleted the pro-wh/feature/lockdelete branch March 6, 2020 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants