Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

txsource: runtime workload #2759

Merged
merged 1 commit into from
Mar 19, 2020
Merged

txsource: runtime workload #2759

merged 1 commit into from
Mar 19, 2020

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Mar 11, 2020 •
edited

Runtime part of: #2506

TODO:

  • validate runtime transaction results

@ptrus ptrus force-pushed the ptrus/feature/runtime-workload branch from f31967b to 71cc3ef Compare March 11, 2020 15:36
@codecov
Copy link

codecov bot commented Mar 11, 2020 •
edited

Codecov Report

Merging #2759 into master will decrease coverage by 0.31%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2759      +/-   ##
==========================================
- Coverage   62.89%   62.58%   -0.32%     
==========================================
  Files         387      387              
  Lines       36379    36540     +161     
==========================================
- Hits        22882    22867      -15     
- Misses      10579    10769     +190     
+ Partials     2918     2904      -14
Impacted Files Coverage Δ
...sis-node/cmd/debug/txsource/workload/delegation.go 0.00% <0.00%> (-65.17%) ⬇️
...oasis-node/cmd/debug/txsource/workload/workload.go 77.77% <ø> (ø)
...s-node/cmd/debug/txsource/workload/registration.go 74.43% <44.44%> (ø)
.../oasis-node/cmd/debug/txsource/workload/runtime.go 57.14% <57.14%> (ø)
go/oasis-node/cmd/debug/txsource/txsource.go 67.69% <100.00%> (+0.50%) ⬆️
...asis-node/cmd/debug/txsource/workload/oversized.go 66.00% <100.00%> (ø)
...oasis-node/cmd/debug/txsource/workload/parallel.go 57.53% <100.00%> (ø)
...oasis-node/cmd/debug/txsource/workload/transfer.go 63.63% <100.00%> (ø)
go/consensus/tendermint/api/api.go 73.58% <0.00%> (-15.10%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40d77ef...3e15dfa. Read the comment docs.

@ptrus ptrus force-pushed the ptrus/feature/runtime-workload branch from 71cc3ef to 5714f7e Compare March 12, 2020 08:54
@ptrus ptrus marked this pull request as ready for review March 12, 2020 09:12
@ptrus ptrus force-pushed the ptrus/feature/runtime-workload branch 6 times, most recently from 13eee0b to 5e41232 Compare March 13, 2020 13:18
kostko
kostko reviewed Mar 13, 2020
View reviewed changes
Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the existing fundAccountAmount in workload.go is too small for longer term tests (e.g., 72h tests). It should be increased at least 10x.

tests/fixture-data/txsource/staking-genesis.json Outdated Show resolved Hide resolved
@ptrus ptrus force-pushed the ptrus/feature/runtime-workload branch 2 times, most recently from caa4f83 to 36461bb Compare March 13, 2020 14:18
@ptrus ptrus force-pushed the ptrus/feature/runtime-workload branch from 36461bb to 3b304e9 Compare March 16, 2020 08:26
@ptrus ptrus mentioned this pull request Mar 16, 2020
Merged
1 task
@ptrus ptrus force-pushed the ptrus/feature/runtime-workload branch 4 times, most recently from 21ccb1f to 46cd483 Compare March 16, 2020 14:38
@ptrus ptrus self-assigned this Mar 16, 2020
@ptrus ptrus mentioned this pull request Mar 17, 2020
Merged
2 tasks
@ptrus ptrus force-pushed the ptrus/feature/runtime-workload branch from 46cd483 to cb565b6 Compare March 17, 2020 13:12
pro-wh
pro-wh reviewed Mar 17, 2020
View reviewed changes
Copy link
Contributor

@pro-wh pro-wh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's change in fees?

go/oasis-node/cmd/debug/txsource/workload/delegation.go Show resolved Hide resolved
go/oasis-node/cmd/debug/txsource/workload/registration.go Outdated Show resolved Hide resolved
go/oasis-node/cmd/debug/txsource/txsource.go Outdated Show resolved Hide resolved
go/oasis-node/cmd/debug/txsource/workload/runtime.go Outdated Show resolved Hide resolved
go/oasis-node/cmd/debug/txsource/workload/runtime.go Outdated Show resolved Hide resolved
go/oasis-node/cmd/debug/txsource/workload/runtime.go Outdated Show resolved Hide resolved
go/oasis-node/cmd/debug/txsource/workload/runtime.go Show resolved Hide resolved
go/oasis-test-runner/scenario/e2e/txsource.go Show resolved Hide resolved
go/oasis-test-runner/scenario/e2e/txsource.go Show resolved Hide resolved
tests/fixture-data/txsource/staking-genesis.json Show resolved Hide resolved
pro-wh
pro-wh reviewed Mar 17, 2020
View reviewed changes
go/oasis-node/cmd/debug/txsource/workload/runtime.go
keyIdx := rng.Intn(len(r.state))
i := 0
for k := range r.state {
if i == keyIdx {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aw man linear scan

@ptrus ptrus force-pushed the ptrus/feature/runtime-workload branch from cb565b6 to 2ba9054 Compare March 18, 2020 08:34
@ptrus ptrus force-pushed the ptrus/feature/runtime-workload branch 2 times, most recently from b92695b to 7d890bb Compare March 18, 2020 09:34
@ptrus
Copy link
Member Author

ptrus commented Mar 18, 2020

tanks for the review comments @pro-wh please check again

pro-wh
pro-wh approved these changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@pro-wh pro-wh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the explanation about the fees and funding.

and the errors are very informative now, thanks

go/oasis-node/cmd/debug/txsource/workload/runtime.go Outdated Show resolved Hide resolved
@ptrus
txsource: runtime workload
3e15dfa 
The added runtime workload submits simiple-keyvalue runtime requests.
@ptrus ptrus force-pushed the ptrus/feature/runtime-workload branch from 7d890bb to 3e15dfa Compare March 19, 2020 08:05
@ptrus ptrus merged commit 3a09db5 into master Mar 19, 2020
@ptrus ptrus deleted the ptrus/feature/runtime-workload branch March 19, 2020 08:39
@ptrus ptrus mentioned this pull request Mar 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostko kostko kostko left review comments

@pro-wh pro-wh pro-wh approved these changes

@peterjgilbert peterjgilbert Awaiting requested review from peterjgilbert peterjgilbert is a code owner

@Yawning Yawning Awaiting requested review from Yawning

Assignees

@ptrus ptrus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ptrus @kostko @pro-wh