Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transfer workload include burns #2773

Merged
merged 2 commits into from
Mar 20, 2020
Merged

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Mar 19, 2020

  • adds staking.Burn transactions to the transfer workload
  • extracts repeated "estimateGas, fund caller, sign tx, submit tx" action into a helper function

@ptrus ptrus self-assigned this Mar 19, 2020
@ptrus ptrus force-pushed the ptrus/feature/transfer-workload-burn branch 3 times, most recently from af32751 to 54ecbab Compare March 19, 2020 14:35
@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #2773 into master will decrease coverage by 0.41%.
The diff coverage is 13.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2773      +/-   ##
==========================================
- Coverage   63.13%   62.71%   -0.42%     
==========================================
  Files         387      387              
  Lines       36540    36526      -14     
==========================================
- Hits        23070    22909     -161     
- Misses      10554    10748     +194     
+ Partials     2916     2869      -47     
Impacted Files Coverage Δ
...sis-node/cmd/debug/txsource/workload/delegation.go 62.60% <0.00%> (-2.56%) ⬇️
...s-node/cmd/debug/txsource/workload/registration.go 75.93% <0.00%> (+1.49%) ⬆️
...oasis-node/cmd/debug/txsource/workload/transfer.go 0.00% <0.00%> (-63.64%) ⬇️
...oasis-node/cmd/debug/txsource/workload/workload.go 67.07% <54.05%> (-10.71%) ⬇️
go/worker/common/host/interface.go 38.46% <0.00%> (-15.39%) ⬇️
go/worker/compute/executor/committee/state.go 74.07% <0.00%> (-11.12%) ⬇️
go/storage/metrics.go 84.78% <0.00%> (-6.53%) ⬇️
go/common/grpc/auth/auth.go 88.88% <0.00%> (-5.56%) ⬇️
go/oasis-node/cmd/debug/byzantine/byzantine.go 35.01% <0.00%> (-5.04%) ⬇️
go/worker/compute/executor/committee/node.go 60.82% <0.00%> (-4.53%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a09db5...78fc3cb. Read the comment docs.

Copy link
Contributor

@pro-wh pro-wh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, is there some other kind of description somewhere we can use better to indicate that the "transfer" workload is 50-50 transfers and burns?

@ptrus ptrus force-pushed the ptrus/feature/transfer-workload-burn branch from 54ecbab to 1e42253 Compare March 20, 2020 08:52
@ptrus ptrus force-pushed the ptrus/feature/transfer-workload-burn branch from 1e42253 to 78fc3cb Compare March 20, 2020 09:17
@ptrus
Copy link
Member Author

ptrus commented Mar 20, 2020

hm, is there some other kind of description somewhere we can use better to indicate that the "transfer" workload is 50-50 transfers and burns?

added a comment to the name constant since i couldn't come up with a workload name better indicating it

@ptrus ptrus merged commit b672167 into master Mar 20, 2020
@ptrus ptrus deleted the ptrus/feature/transfer-workload-burn branch March 20, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants