Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/txsource/queries: Wait for indexed blocks before GetBlockByHash #2814

Merged
merged 2 commits into from
Apr 2, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Apr 2, 2020

No description provided.

@kostko kostko requested a review from ptrus April 2, 2020 09:19
@kostko kostko force-pushed the kostko/fix/txsource-rt-query-blkhash branch from acf452c to 73508e0 Compare April 2, 2020 09:19
@codecov
Copy link

codecov bot commented Apr 2, 2020

Codecov Report

Merging #2814 into master will increase coverage by 0.72%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2814      +/-   ##
==========================================
+ Coverage   61.27%   62.00%   +0.72%     
==========================================
  Files         386      386              
  Lines       37247    37264      +17     
==========================================
+ Hits        22824    23105     +281     
+ Misses      11439    11103     -336     
- Partials     2984     3056      +72     
Impacted Files Coverage Δ
.../oasis-node/cmd/debug/txsource/workload/queries.go 53.51% <60.00%> (+52.54%) ⬆️
go/runtime/committee/nodes.go 80.64% <0.00%> (-2.16%) ⬇️
go/worker/common/p2p/p2p.go 62.61% <0.00%> (-1.81%) ⬇️
go/worker/storage/committee/checkpointer.go 66.37% <0.00%> (-1.77%) ⬇️
go/runtime/client/watcher.go 73.84% <0.00%> (-1.54%) ⬇️
go/runtime/client/client.go 67.52% <0.00%> (-0.74%) ⬇️
go/roothash/tests/tester.go 95.54% <0.00%> (-0.64%) ⬇️
go/storage/mkvs/db/badger/badger.go 52.91% <0.00%> (+0.44%) ⬆️
go/worker/keymanager/worker.go 60.00% <0.00%> (+0.59%) ⬆️
go/common/grpc/grpc.go 78.83% <0.00%> (+1.24%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70011b1...7fb0c93. Read the comment docs.

The purpose of this timeout is to prevent the client being stuck and treating
that as an error instead.
@kostko kostko force-pushed the kostko/fix/txsource-rt-query-blkhash branch from 130a42f to 7fb0c93 Compare April 2, 2020 16:20
@kostko kostko merged commit ce667e7 into master Apr 2, 2020
@kostko kostko deleted the kostko/fix/txsource-rt-query-blkhash branch April 2, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants