Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/extra/stats: Update availability formula #2819

Merged
merged 1 commit into from
Apr 3, 2020

Conversation

peterjgilbert
Copy link
Contributor

@peterjgilbert peterjgilbert commented Apr 3, 2020

As per https://docs.oasis.dev/operators/the-quest-rules.html#types-of-challenges, the availability score formula has changed from Blocks Signed + 50 x Blocks Proposed to Blocks Signed + 50 x Blocks Proposed in Round 0.

@peterjgilbert peterjgilbert force-pushed the peterjgilbert/fix/availability_formula branch 2 times, most recently from fabe6b8 to 1a349e4 Compare April 3, 2020 18:15
@peterjgilbert peterjgilbert force-pushed the peterjgilbert/fix/availability_formula branch from 1a349e4 to d021b4f Compare April 3, 2020 18:18
@codecov
Copy link

codecov bot commented Apr 3, 2020

Codecov Report

Merging #2819 into master will increase coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2819      +/-   ##
==========================================
+ Coverage   65.77%   66.00%   +0.23%     
==========================================
  Files         342      342              
  Lines       32579    32579              
==========================================
+ Hits        21428    21503      +75     
+ Misses       8448     8389      -59     
+ Partials     2703     2687      -16     
Impacted Files Coverage Δ
go/common/cbor/codec.go 64.70% <0.00%> (-5.89%) ⬇️
go/common/grpc/auth/auth.go 88.88% <0.00%> (-5.56%) ⬇️
go/storage/api/grpc.go 69.89% <0.00%> (-0.67%) ⬇️
go/roothash/tests/tester.go 95.54% <0.00%> (-0.64%) ⬇️
go/worker/keymanager/worker.go 59.40% <0.00%> (-0.60%) ⬇️
go/common/grpc/grpc.go 78.42% <0.00%> (-0.42%) ⬇️
go/consensus/tendermint/tendermint.go 68.11% <0.00%> (+0.27%) ⬆️
go/storage/mkvs/db/badger/badger.go 52.91% <0.00%> (+0.44%) ⬆️
go/runtime/client/client.go 68.26% <0.00%> (+0.73%) ⬆️
go/worker/compute/merge/committee/node.go 76.61% <0.00%> (+0.99%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 364f920...d021b4f. Read the comment docs.

Copy link
Contributor

@pro-wh pro-wh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

now that we need to look at the commit info for each block, we have to look one block ahead, when the commit info is agreed upon. and when we looking one block ahead, we have to remember the proposer for the block we're evaluating the score for

@peterjgilbert peterjgilbert changed the title stats: update availability formula go/extra/stats: Update availability formula Apr 3, 2020
@peterjgilbert peterjgilbert merged commit 4aca538 into master Apr 3, 2020
@peterjgilbert peterjgilbert deleted the peterjgilbert/fix/availability_formula branch April 3, 2020 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants