Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sentry: Replace policy watcher with API command #2820

Closed
abukosek opened this issue Apr 4, 2020 · 0 comments · Fixed by #3039
Closed

sentry: Replace policy watcher with API command #2820

abukosek opened this issue Apr 4, 2020 · 0 comments · Fixed by #3039
Assignees
Labels

Comments

@abukosek
Copy link
Contributor

abukosek commented Apr 4, 2020

Currently, the sentry gRPC worker (worker/sentry/grpc/worker.go) watches for policy changes, but that is unnecessary, since the upstream node can simply push the changes to the sentry using a new sentry API command (e.g. UpdatePolicies) in a similar way as was recently done with SetUpstreamTLSCertificates in PR #2675.

This would also enable simplification of the sentry gRPC worker code (e.g. not storing the connection dialed in initConnection() in the worker struct, removing other cruft, etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant