keyamanger-runtime: replace with test/simple-keymanager #2837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
requested review from
kostko,
peterjgilbert,
pro-wh and
Yawning
as code owners
ptrus
force-pushed
the
ptrus/internal/cleanup-keymanager-runtime
branch
3 times, most recently
from
24412c8
to
797e56c
Compare
5 tasks
Codecov Report
@@ Coverage Diff @@
## master #2837 +/- ##
==========================================
+ Coverage 67.37% 67.51% +0.14%
==========================================
Files 344 344
Lines 33071 33089 +18
==========================================
+ Hits 22280 22340 +60
+ Misses 7910 7863 -47
- Partials 2881 2886 +5
Continue to review full report at Codecov.
|
kostko
reviewed
Apr 13, 2020
ptrus
force-pushed
the
ptrus/internal/cleanup-keymanager-runtime
branch
from
797e56c
to
de2f3ca
Compare
ptrus
force-pushed
the
ptrus/internal/cleanup-keymanager-runtime
branch
3 times, most recently
from
f55cdff
to
20e2c32
Compare
kostko
approved these changes
Apr 14, 2020
Common keymanager initalization code is extracted into the `keymanager-lib` crate. This enables for the actual key manager implementation to only provide a set of key manager policy signers. Aditionally the `keymanager-runtime` crate is removed and replaced with a test `simple-keymanager` runtime that is used in E2E tests.
ptrus
force-pushed
the
ptrus/internal/cleanup-keymanager-runtime
branch
from
45d98da
to
bf9365d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Common keymanager initalization code is extracted into the
keymanager-libcrate. This enables for the actual key manager implementation to only
provide a set of key manager policy signers.
Aditionally the
keymanager-runtimecrate is removed and replaced witha test
simple-keymanagerruntime that is used in E2E tests.(not sure if "simple-keymanager" is the correct name)
TODO: