Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: remove docker image build and cleanup images #2838

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Apr 13, 2020

With oasislabs/oasis-ethwasi-runtime#985 the docker image built from Oasis Core is not needed anymore. This PR can be merged, but the buildkite pipeline itself should not be deleted until the Oasis Runtime PR is merged.

  • Removes deployment related docker stuff
  • cleans up testing dockerifle

TODO:

  • test (also needs to be tested in oasis-runtime pipeline)
  • update existing oasislabs/testing:0.3.0 image (after this is approved and ready to merge)

@ptrus ptrus force-pushed the ptrus/internal/cleanup-docker branch from 87fd786 to efc82a1 Compare April 13, 2020 14:51
@codecov
Copy link

codecov bot commented Apr 13, 2020

Codecov Report

Merging #2838 into master will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2838      +/-   ##
==========================================
+ Coverage   67.27%   67.47%   +0.19%     
==========================================
  Files         344      344              
  Lines       33089    33089              
==========================================
+ Hits        22262    22328      +66     
+ Misses       7924     7887      -37     
+ Partials     2903     2874      -29     
Impacted Files Coverage Δ
go/common/cbor/codec.go 77.14% <0.00%> (-5.72%) ⬇️
go/worker/storage/service_external.go 47.31% <0.00%> (-4.31%) ⬇️
go/consensus/tendermint/roothash/roothash.go 68.91% <0.00%> (-2.63%) ⬇️
go/worker/common/p2p/p2p.go 64.41% <0.00%> (-1.81%) ⬇️
go/common/grpc/grpc.go 79.42% <0.00%> (-1.24%) ⬇️
go/consensus/tendermint/abci/mux.go 68.91% <0.00%> (-0.46%) ⬇️
go/worker/compute/merge/committee/node.go 75.87% <0.00%> (-0.25%) ⬇️
go/consensus/tendermint/tendermint.go 68.07% <0.00%> (+0.27%) ⬆️
.../consensus/tendermint/apps/registry/state/state.go 61.00% <0.00%> (+0.53%) ⬆️
go/consensus/tendermint/abci/state.go 70.27% <0.00%> (+1.15%) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0757868...1a8bb0e. Read the comment docs.

@ptrus ptrus force-pushed the ptrus/internal/cleanup-docker branch from efc82a1 to 08375e5 Compare April 14, 2020 07:15
@ptrus ptrus marked this pull request as ready for review April 14, 2020 07:40
@ptrus ptrus force-pushed the ptrus/internal/cleanup-docker branch 3 times, most recently from 1ba213a to 4c38848 Compare April 14, 2020 11:30
@ptrus ptrus force-pushed the ptrus/internal/cleanup-docker branch from 4c38848 to 1a8bb0e Compare April 14, 2020 11:51
@ptrus ptrus merged commit b8522c9 into master Apr 14, 2020
@ptrus ptrus deleted the ptrus/internal/cleanup-docker branch April 14, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants