Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oasis-net-runner: Add support for loading fixtures from JSON #2848

Merged
merged 1 commit into from
Apr 24, 2020
Merged

oasis-net-runner: Add support for loading fixtures from JSON #2848

merged 1 commit into from
Apr 24, 2020

Conversation

matevz
Copy link
Member

@matevz matevz commented Apr 16, 2020 •
edited

@matevz matevz force-pushed the matevz/feature/json_fixtures branch 3 times, most recently from 4e00ccb to 902f729 Compare April 17, 2020 08:58
@matevz matevz marked this pull request as ready for review April 17, 2020 08:58
kostko
kostko reviewed Apr 17, 2020
View reviewed changes
Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an example fixture under tests/fixture-data/net-runner/default.json.

Also add some unit tests for dumping/loading a fixture and making sure it looks correct.

go/oasis-net-runner/fixtures/default.go Outdated Show resolved Hide resolved
go/oasis-net-runner/fixtures/default.go Outdated Show resolved Hide resolved
go/oasis-net-runner/fixtures/default.go Outdated Show resolved Hide resolved
go/oasis-net-runner/fixtures/default.go Outdated Show resolved Hide resolved
go/oasis-net-runner/fixtures/default.go Outdated Show resolved Hide resolved
@kostko kostko linked an issue Apr 20, 2020 that may be closed by this pull request
Support specifying JSON fixtures in oasis-net-runner #2779
Closed
@matevz matevz force-pushed the matevz/feature/json_fixtures branch from 902f729 to 55ff06d Compare April 20, 2020 14:52
@codecov
Copy link

codecov bot commented Apr 20, 2020 •
edited

Codecov Report

Merging #2848 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2848      +/-   ##
==========================================
+ Coverage   67.64%   67.74%   +0.09%     
==========================================
  Files         344      344              
  Lines       33530    33530              
==========================================
+ Hits        22682    22714      +32     
+ Misses       7922     7900      -22     
+ Partials     2926     2916      -10
Impacted Files Coverage Δ
go/worker/compute/executor/committee/state.go 85.18% <0.00%> (-14.82%) ⬇️
go/worker/storage/service_external.go 47.31% <0.00%> (-4.31%) ⬇️
go/worker/compute/executor/committee/node.go 65.35% <0.00%> (-3.15%) ⬇️
go/consensus/tendermint/apps/staking/fees.go 38.39% <0.00%> (-1.79%) ⬇️
...consensus/tendermint/apps/registry/transactions.go 48.64% <0.00%> (-1.64%) ⬇️
go/consensus/tendermint/apps/staking/staking.go 54.28% <0.00%> (-1.43%) ⬇️
.../consensus/tendermint/apps/registry/state/state.go 59.94% <0.00%> (-1.07%) ⬇️
go/consensus/tendermint/abci/mux.go 68.30% <0.00%> (-0.90%) ⬇️
go/registry/api/api.go 37.57% <0.00%> (-0.89%) ⬇️
go/storage/mkvs/insert.go 90.47% <0.00%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fcdd59...b2b5339. Read the comment docs.

@matevz matevz force-pushed the matevz/feature/json_fixtures branch 4 times, most recently from d25e189 to 00f7d6f Compare April 21, 2020 15:04
kostko
kostko reviewed Apr 21, 2020
View reviewed changes
.changelog/2848.breaking.md Show resolved Hide resolved
go/oasis-net-runner/cmd/root.go Outdated Show resolved Hide resolved
go/oasis-net-runner/fixtures/fixtures.go Outdated Show resolved Hide resolved
go/oasis-net-runner/fixtures/fixtures_test.go Outdated Show resolved Hide resolved
go/oasis-net-runner/fixtures/fixtures_test.go Outdated Show resolved Hide resolved
kostko
kostko reviewed Apr 22, 2020
View reviewed changes
go/oasis-net-runner/fixtures/fixtures.go Outdated Show resolved Hide resolved
go/oasis-net-runner/cmd/root.go Outdated Show resolved Hide resolved
go/oasis-net-runner/fixtures/fixtures.go Outdated Show resolved Hide resolved
@matevz matevz mentioned this pull request Apr 22, 2020
Merged
@matevz matevz force-pushed the matevz/feature/json_fixtures branch from c01cd1c to c80853b Compare April 22, 2020 14:47
@matevz matevz force-pushed the matevz/feature/json_fixtures branch from c80853b to 21e08c2 Compare April 23, 2020 10:26
@kostko
Copy link
Member

kostko commented Apr 23, 2020

Don't forget to squash :-)

@matevz matevz force-pushed the matevz/feature/json_fixtures branch from 21e08c2 to b2b5339 Compare April 24, 2020 10:04
@matevz matevz merged commit e9945c8 into master Apr 24, 2020
@matevz matevz deleted the matevz/feature/json_fixtures branch April 24, 2020 10:29
@matevz
Copy link
Member Author

matevz commented Apr 24, 2020

Merged, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostko kostko kostko approved these changes

@peterjgilbert peterjgilbert Awaiting requested review from peterjgilbert peterjgilbert is a code owner

@pro-wh pro-wh Awaiting requested review from pro-wh pro-wh is a code owner

@Yawning Yawning Awaiting requested review from Yawning

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support specifying JSON fixtures in oasis-net-runner
2 participants
@matevz @kostko