tendermint unconditional peers #2855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
requested review from
kostko,
peterjgilbert,
pro-wh and
Yawning
as code owners
ptrus
force-pushed
the
ptrus/feature/tendermint-unconditional-peers
branch
2 times, most recently
from
b4425ab
to
228771d
Compare
Codecov Report
@@ Coverage Diff @@
## master #2855 +/- ##
==========================================
+ Coverage 67.33% 67.56% +0.22%
==========================================
Files 344 344
Lines 33406 33411 +5
==========================================
+ Hits 22495 22575 +80
+ Misses 8007 7940 -67
+ Partials 2904 2896 -8
Continue to review full report at Codecov.
|
kostko
reviewed
Apr 19, 2020
ptrus
force-pushed
the
ptrus/feature/tendermint-unconditional-peers
branch
from
228771d
to
9380f6b
Compare
Tendermint 0.33 added the concept of unconditional P2P peers. This adds support for setting the unconditional peers via `tendermint.p2p.unconditional_peer_ids` configuration flag. On sentry node, upstream nodes will automatically be set as unconditional peers.
ptrus
force-pushed
the
ptrus/feature/tendermint-unconditional-peers
branch
from
9380f6b
to
492f835
Compare
ptrus
force-pushed
the
ptrus/feature/tendermint-unconditional-peers
branch
2 times, most recently
from
a3f9c74
to
24eb89f
Compare
kostko
approved these changes
Apr 20, 2020
Tendermint 0.33 added support for setting maximum re-dial period when dialing persistent peers. This adds support for setting the period via `tendermint.p2p.persistent_peers_max_dial_period` flag.
ptrus
force-pushed
the
ptrus/feature/tendermint-unconditional-peers
branch
from
24eb89f
to
b949606
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose new p2p config options which were added in tendermint 0.33