go/extra/stats: fix & simplify node-entity mapping #2856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
requested review from
kostko,
peterjgilbert,
pro-wh and
Yawning
as code owners
Instead of separately querying for entities and nodes, we can get Entity IDs from nodes directly. This change also fixes a case that previous variant missed: node that was removed from entity list of nodes, but has not yet expired.
ptrus
force-pushed
the
ptrus/fix/stats-nodes
branch
from
9019508
to
f31cf9a
Compare
kostko
approved these changes
Apr 20, 2020
This was referenced Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2854
Instead of separately querying for entities and nodes, we can get Entity IDs
from nodes directly.
This change also fixes a case that previous variant missed: node that was
removed from entity list of nodes, but has not yet expired.
TODO: