Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/keymanager/client(?): Intermittent errors when committe size > 1 #2885

Closed
Yawning opened this issue May 5, 2020 · 1 comment · Fixed by #2887 or #2888
Closed

go/keymanager/client(?): Intermittent errors when committe size > 1 #2885

Yawning opened this issue May 5, 2020 · 1 comment · Fixed by #2887 or #2888
Assignees
Labels
c:bug Category: bug c:client Category: client interface c:keymgmt Category: key management p:0 Priority: High! bugs, address immediately

Comments

@Yawning
Copy link
Contributor

Yawning commented May 5, 2020

I have been told that there is retry logic, and both the rust enclave RPC and go key manager clients appear to have something that looks like retry logic.

That said, when there is more than one node in a key manager committee, a simple non-enclave key manager request (via gRPC) from rust code intermittently fails with the following panic:

Testing key manager connection via gRPC transport...
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: RpcFailure(RpcStatus { status: Unknown, details: Some("worker/keymanager: error from runtime: decrypt error") })', tests/clients/simple-keyvalue-enc/src/main.rs:99:13
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Node logs: https://buildkite.com/oasislabs/oasis-core-ci/builds/3614 (The keymanager-replication tests in the 6/7 non-sgx group)

I assume something, somewhere should be re-establishing the session as part of the retry logic, or something somewhere shouldn't be as happy to swap to a different node.

@Yawning Yawning added p:0 Priority: High! bugs, address immediately c:client Category: client interface c:keymgmt Category: key management c:bug Category: bug labels May 5, 2020
@kostko kostko self-assigned this May 5, 2020
@kostko
Copy link
Member

kostko commented May 5, 2020

It seems this is not yet fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:bug Category: bug c:client Category: client interface c:keymgmt Category: key management p:0 Priority: High! bugs, address immediately
Projects
None yet
2 participants