go stats: new availability v3 formula #2896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2896 +/- ##
==========================================
+ Coverage 67.80% 67.94% +0.13%
==========================================
Files 352 352
Lines 34235 34232 -3
==========================================
+ Hits 23214 23259 +45
+ Misses 8032 7974 -58
- Partials 2989 2999 +10
Continue to review full report at Codecov.
|
kostko
reviewed
May 8, 2020
| lastCommitHeight := height - 1 | ||
|
|
||
| // Get validators. | ||
| // Hypothesis: this gets the validator set with priorities after they're incremented to get the round 0 |
There was a problem hiding this comment.
I assume you checked that this is actually the case?
There was a problem hiding this comment.
I get the gist of it now
pro-wh
force-pushed
the
pro-wh/feature/roundrobin
branch
from
caaf7d6
to
bf55c72
Compare
kostko
approved these changes
May 11, 2020
pro-wh
force-pushed
the
pro-wh/feature/roundrobin
branch
from
bf55c72
to
9e9c6b9
Compare
pro-wh
added a commit
that referenced
this pull request
Jun 4, 2020
go stats: new availability v3 formula
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
here's the implementation of the new availability score v3 for May