Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics.labels not parsed correctly for .yml configs #2905

Closed
matevz opened this issue May 12, 2020 · 0 comments · Fixed by #2906
Closed

metrics.labels not parsed correctly for .yml configs #2905

matevz opened this issue May 12, 2020 · 0 comments · Fixed by #2906
Assignees
@matevz
Labels
c:cli Category: command line interface c:instrumentation Category: metrics and tracing p:0 Priority: High! bugs, address immediately

Comments

@matevz
Copy link
Member

matevz commented May 12, 2020 •
edited

Running oasis-node --metrics.labels foo1=bar1,foo2=bar2 works. However, making a yaml file:

metrics:
  labels:
    foo1: bar1
    foo2: bar2

complains that no labels have been passed.

This regression was caused by #2687.
@matevz matevz added p:0 Priority: High! bugs, address immediately c:instrumentation Category: metrics and tracing c:cli Category: command line interface labels May 12, 2020
@matevz matevz self-assigned this May 12, 2020
@matevz matevz mentioned this issue May 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matevz matevz

Labels
c:cli Category: command line interface c:instrumentation Category: metrics and tracing p:0 Priority: High! bugs, address immediately
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

common/flags: Fix parsing of metrics.labels, if provided in config .yml oasisprotocol/oasis-core
1 participant
@matevz