Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go stats: give ties the same rank #2908

Merged
merged 2 commits into from
May 13, 2020
Merged

go stats: give ties the same rank #2908

merged 2 commits into from
May 13, 2020

Conversation

pro-wh
Copy link
Contributor

@pro-wh pro-wh commented May 12, 2020

we don't use the "Rank" column from the stats program because it's wrong on ties. we probably still can't use it directly because we often need to combine it across upgrades. but here's some logic to give ties the same rank.

@pro-wh pro-wh requested a review from ptrus May 12, 2020 20:30
@pro-wh pro-wh force-pushed the pro-wh/feature/rank branch 2 times, most recently from 398938e to 3d7cf04 Compare May 12, 2020 22:32
@codecov
Copy link

codecov bot commented May 12, 2020

Codecov Report

Merging #2908 into master will decrease coverage by 0.27%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2908      +/-   ##
==========================================
- Coverage   68.16%   67.88%   -0.28%     
==========================================
  Files         354      354              
  Lines       34347    34347              
==========================================
- Hits        23414    23318      -96     
- Misses       7960     8033      +73     
- Partials     2973     2996      +23     
Impacted Files Coverage Δ
go/consensus/tendermint/api/errors.go 86.66% <0.00%> (-13.34%) ⬇️
go/storage/metrics.go 81.52% <0.00%> (-9.79%) ⬇️
go/storage/api/root_cache.go 70.11% <0.00%> (-6.90%) ⬇️
...ompute/txnscheduler/algorithm/batching/batching.go 78.66% <0.00%> (-6.67%) ⬇️
go/storage/database/database.go 75.45% <0.00%> (-5.46%) ⬇️
go/storage/mkvs/insert.go 87.75% <0.00%> (-5.45%) ⬇️
go/runtime/client/watcher.go 73.84% <0.00%> (-4.62%) ⬇️
go/consensus/tendermint/apps/staking/state/gas.go 77.08% <0.00%> (-4.17%) ⬇️
go/storage/mkvs/tree.go 89.28% <0.00%> (-3.58%) ⬇️
go/storage/client/client.go 75.33% <0.00%> (-2.65%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fe975e...ff6eeb5. Read the comment docs.

@pro-wh pro-wh merged commit 9152bad into master May 13, 2020
@pro-wh pro-wh deleted the pro-wh/feature/rank branch May 13, 2020 19:35
pro-wh added a commit that referenced this pull request Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants