Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/common/keyformat: Add support for hashed key elements #2929

Merged
merged 2 commits into from
May 22, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented May 21, 2020

Add support for hashed key elements and hash some of the key elements.

Staking state is omitted as it will not be needed once we do #2928 (as all account identifiers will already be hashed then).

@kostko kostko force-pushed the kostko/feature/kf-hashed-state branch 4 times, most recently from b26f4e2 to 90578c7 Compare May 21, 2020 09:32
@codecov
Copy link

codecov bot commented May 21, 2020

Codecov Report

Merging #2929 into master will increase coverage by 0.00%.
The diff coverage is 71.90%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #2929    +/-   ##
========================================
  Coverage   68.46%   68.47%            
========================================
  Files         360      361     +1     
  Lines       34947    35086   +139     
========================================
+ Hits        23926    24024    +98     
- Misses       7941     7967    +26     
- Partials     3080     3095    +15     
Impacted Files Coverage Δ
go/consensus/tendermint/abci/mux.go 69.97% <ø> (-1.39%) ⬇️
go/storage/mkvs/db/api/api.go 60.46% <ø> (ø)
go/storage/database/database.go 70.58% <11.11%> (-4.87%) ⬇️
go/storage/mkvs/db/badger/badger.go 70.24% <25.00%> (-0.81%) ⬇️
go/consensus/tendermint/abci/state.go 68.00% <44.82%> (-1.24%) ⬇️
.../consensus/tendermint/apps/epochtime_mock/query.go 81.81% <50.00%> (-18.19%) ⬇️
go/runtime/host/protocol/connection.go 61.53% <60.00%> (-0.56%) ⬇️
go/consensus/tendermint/abci/timer.go 67.00% <66.66%> (-0.02%) ⬇️
...consensus/tendermint/apps/scheduler/state/state.go 71.15% <71.42%> (ø)
go/common/keyformat/key_format.go 75.65% <73.84%> (+1.11%) ⬆️
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66ec66e...1f33d64. Read the comment docs.

@kostko kostko added the c:breaking/consensus Category: breaking consensus changes label May 21, 2020
@kostko kostko force-pushed the kostko/feature/kf-hashed-state branch from 90578c7 to 3193b5a Compare May 21, 2020 09:51
@kostko kostko marked this pull request as ready for review May 21, 2020 09:51
go/common/keyformat/hashed.go Outdated Show resolved Hide resolved
@kostko kostko force-pushed the kostko/feature/kf-hashed-state branch from 3193b5a to d8de6b7 Compare May 22, 2020 11:24
@kostko kostko force-pushed the kostko/feature/kf-hashed-state branch from d8de6b7 to 1f33d64 Compare May 22, 2020 11:25
@kostko kostko merged commit 407e098 into master May 22, 2020
@kostko kostko deleted the kostko/feature/kf-hashed-state branch May 22, 2020 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:breaking/consensus Category: breaking consensus changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants