Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support blacklisting public keys via a consensus parameter #2948

Closed
Yawning opened this issue May 27, 2020 · 1 comment · Fixed by #2959
Closed

Support blacklisting public keys via a consensus parameter #2948

Yawning opened this issue May 27, 2020 · 1 comment · Fixed by #2959
Assignees
@Yawning
Labels
c:consensus/tendermint Category: Tendermint-based consensus c:security Category: security issues

Comments

@Yawning
Copy link
Contributor

Yawning commented May 27, 2020

Our signer code has a notion of a public key blacklist, that is used to reject test keys among other things.

This should be expanded on, and support for rejecting keys based on something that is consensus backed (eg: a genesis document field), should be added so that it is possible to reject keys at the consensus layer.
@Yawning Yawning added c:consensus/tendermint Category: Tendermint-based consensus c:security Category: security issues labels May 27, 2020
@kostko kostko linked a pull request Jun 1, 2020 that will close this issue
go/consensus/genesis: Add a public key blacklist #2959
Merged
4 tasks
@kostko
Copy link
Member

kostko commented Jun 1, 2020

Done in #2959.

@kostko kostko closed this as completed Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yawning Yawning

Labels
c:consensus/tendermint Category: Tendermint-based consensus c:security Category: security issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

go/consensus/genesis: Add a public key blacklist oasisprotocol/oasis-core
2 participants
@kostko @Yawning