Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composite signer configuration is not possible in YAML #2949

Closed
kostko opened this issue May 27, 2020 · 0 comments · Fixed by #2951
Closed

Composite signer configuration is not possible in YAML #2949

kostko opened this issue May 27, 2020 · 0 comments · Fixed by #2951
Assignees
@kostko
Labels
c:bug Category: bug c:cli Category: command line interface

Comments

@kostko
Copy link
Member

kostko commented May 27, 2020

The problem is that we currently define the signer backend argument as simply signer and all the other arguments are nested under it, like signer.composite.backends. And while you can do --signer composite --signer.composite.backends 1:file you cannot this in YAML as signer would need to be both a string and a map.

We should probably rename signer to signer.backend.
@kostko kostko added c:bug Category: bug c:cli Category: command line interface labels May 27, 2020
@kostko kostko self-assigned this May 28, 2020
@kostko kostko mentioned this issue May 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kostko kostko

Labels
c:bug Category: bug c:cli Category: command line interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

go/oasis-node: Signer configuration fixes oasisprotocol/oasis-core
1 participant
@kostko