oasis-node: Add support for IsReady and WaitReady RPC methods #2957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matevz
force-pushed
the
matevz/feature/waitready-rpc
branch
2 times, most recently
from
7396a7d
to
0b49973
Compare
matevz
requested review from
kostko,
peterjgilbert,
pro-wh and
Yawning
as code owners
matevz
force-pushed
the
matevz/feature/waitready-rpc
branch
from
0b49973
to
3cf5b4c
Compare
kostko
previously requested changes
Jun 1, 2020
matevz
force-pushed
the
matevz/feature/waitready-rpc
branch
3 times, most recently
from
fc7b0ea
to
254adaf
Compare
ptrus
reviewed
Jun 2, 2020
ptrus
reviewed
Jun 2, 2020
matevz
force-pushed
the
matevz/feature/waitready-rpc
branch
from
6532e73
to
42da091
Compare
kostko
reviewed
Jun 3, 2020
matevz
force-pushed
the
matevz/feature/waitready-rpc
branch
from
0cea87a
to
5526cb7
Compare
Codecov Report
@@ Coverage Diff @@
## master #2957 +/- ##
==========================================
- Coverage 68.74% 68.47% -0.28%
==========================================
Files 360 360
Lines 35285 35386 +101
==========================================
- Hits 24258 24229 -29
- Misses 7922 8040 +118
- Partials 3105 3117 +12
Continue to review full report at Codecov.
|
matevz
force-pushed
the
matevz/feature/waitready-rpc
branch
3 times, most recently
from
99e21da
to
a7cff7b
Compare
kostko
reviewed
Jun 4, 2020
matevz
force-pushed
the
matevz/feature/waitready-rpc
branch
from
a7cff7b
to
7b3bc49
Compare
kostko
force-pushed
the
matevz/feature/waitready-rpc
branch
3 times, most recently
from
995a6f2
to
012243f
Compare
kostko
force-pushed
the
matevz/feature/waitready-rpc
branch
2 times, most recently
from
7e2a2d2
to
b46a1e4
Compare
matevz
commented
Jun 5, 2020
kostko
force-pushed
the
matevz/feature/waitready-rpc
branch
3 times, most recently
from
ccba4d3
to
ce3d617
Compare
The new method allows the caller to register a callback that will be invoked on a successful registration that includes the node descriptor updated by the passed hook.
kostko
force-pushed
the
matevz/feature/waitready-rpc
branch
from
ce3d617
to
259a147
Compare
kostko
force-pushed
the
matevz/feature/waitready-rpc
branch
from
259a147
to
d0551ab
Compare
kostko
reviewed
Jun 8, 2020
| // Calls can fail around epoch transitions, as the access policy | ||
| // is being updated, so we must retry. | ||
| return err | ||
| case status.Code(err) == codes.Unavailable: | ||
| // XXX: HACK: Find a better way to determine the root cause. | ||
| if strings.Contains(err.Error(), "tls: bad public key") { |
There was a problem hiding this comment.
Unfortunately, due to gRPC's use of wrapping RPC errors (see here) it is not possible to get the original error.
kostko
approved these changes
Jun 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2130