Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: don't retry timeout jobs #2969

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Jun 2, 2020

Apparently jobs that hit the time-out limit exit with status -1 and get automatically retried (which we actually don't want). Haven't seen any other job fail with -1 (agents getting killed appears to be 125) so i think it's fine just not retrying these.

@ptrus ptrus force-pushed the ptrus/fix/buildkite-restart-timeout branch from a57f36f to 3de92a1 Compare June 2, 2020 11:56
@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #2969 into master will decrease coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2969      +/-   ##
==========================================
- Coverage   68.55%   68.32%   -0.23%     
==========================================
  Files         361      361              
  Lines       35231    35231              
==========================================
- Hits        24151    24073      -78     
- Misses       7968     8052      +84     
+ Partials     3112     3106       -6     
Impacted Files Coverage Δ
go/consensus/tendermint/apps/scheduler/query.go 71.05% <0.00%> (-7.90%) ⬇️
go/consensus/tendermint/apps/staking/query.go 49.09% <0.00%> (-7.28%) ⬇️
...ompute/txnscheduler/algorithm/batching/batching.go 78.66% <0.00%> (-6.67%) ⬇️
go/storage/metrics.go 81.52% <0.00%> (-6.53%) ⬇️
go/staking/api/grpc.go 52.61% <0.00%> (-6.21%) ⬇️
go/common/cbor/codec.go 78.37% <0.00%> (-5.41%) ⬇️
go/registry/api/grpc.go 35.16% <0.00%> (-4.90%) ⬇️
go/worker/storage/service_external.go 47.31% <0.00%> (-4.31%) ⬇️
go/runtime/committee/nodes.go 80.39% <0.00%> (-3.93%) ⬇️
go/storage/database/database.go 70.58% <0.00%> (-3.37%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83e9a9b...3de92a1. Read the comment docs.

@ptrus ptrus merged commit d490d3e into master Jun 2, 2020
@ptrus ptrus deleted the ptrus/fix/buildkite-restart-timeout branch June 30, 2020 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants