Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registry: Add runtime-specific staking thresholds #2995

Merged
merged 1 commit into from
Jun 11, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Jun 10, 2020

TODO

  • Tests (also improves existing registry tests).

@kostko kostko added the c:breaking/consensus Category: breaking consensus changes label Jun 10, 2020
@kostko kostko force-pushed the kostko/feature/rt-min-stake branch 9 times, most recently from 6089716 to 9ac7171 Compare June 11, 2020 10:51
@kostko kostko marked this pull request as ready for review June 11, 2020 10:56
@kostko kostko force-pushed the kostko/feature/rt-min-stake branch 2 times, most recently from fca8526 to 80648e6 Compare June 11, 2020 12:35
@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #2995 into master will decrease coverage by 0.02%.
The diff coverage is 82.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2995      +/-   ##
==========================================
- Coverage   68.45%   68.42%   -0.03%     
==========================================
  Files         365      365              
  Lines       35679    35834     +155     
==========================================
+ Hits        24423    24521      +98     
- Misses       8111     8155      +44     
- Partials     3145     3158      +13     
Impacted Files Coverage Δ
go/common/quantity/quantity.go 88.07% <0.00%> (-4.24%) ⬇️
...ensus/tendermint/apps/staking/state/accumulator.go 67.16% <ø> (ø)
go/oasis-node/cmd/registry/runtime/runtime.go 58.75% <55.55%> (-0.31%) ⬇️
go/registry/api/api.go 40.51% <71.42%> (+1.19%) ⬆️
...consensus/tendermint/apps/registry/transactions.go 54.08% <75.00%> (+4.08%) ⬆️
go/registry/api/runtime.go 49.47% <75.00%> (+5.16%) ⬆️
go/staking/api/api.go 74.11% <81.08%> (+2.68%) ⬆️
go/registry/api/sanity_check.go 59.11% <88.88%> (+1.12%) ⬆️
go/registry/tests/tester.go 91.59% <100.00%> (+0.32%) ⬆️
go/upgrade/migrations/dummy.go 80.00% <100.00%> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10f076d...c4d3bdd. Read the comment docs.

@kostko kostko force-pushed the kostko/feature/rt-min-stake branch from 80648e6 to c4d3bdd Compare June 11, 2020 13:41
@kostko kostko merged commit 8ee232f into master Jun 11, 2020
@kostko kostko deleted the kostko/feature/rt-min-stake branch June 11, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:breaking/consensus Category: breaking consensus changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants