Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/txsource: fix queries workload earliest committee epoch #3001

Merged
merged 1 commit into from
Jun 10, 2020

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Jun 10, 2020

Keymanager actually registers in epoch 1, not sure if this is due to a recent change (e.g. the WaitFor() changes) or it was always like that

This was a reason for a failure in one of the recent longtests runs

@ptrus ptrus force-pushed the ptrus/fix/queries-workload branch 2 times, most recently from 853cfb2 to 609d364 Compare June 10, 2020 12:23
@ptrus ptrus force-pushed the ptrus/fix/queries-workload branch from 609d364 to da790a1 Compare June 10, 2020 12:49
@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #3001 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3001      +/-   ##
==========================================
- Coverage   68.46%   68.45%   -0.02%     
==========================================
  Files         360      360              
  Lines       35382    35382              
==========================================
- Hits        24226    24222       -4     
- Misses       8011     8028      +17     
+ Partials     3145     3132      -13     
Impacted Files Coverage Δ
go/storage/mkvs/writelog/iterator.go 76.36% <0.00%> (-16.37%) ⬇️
go/worker/compute/executor/committee/state.go 74.07% <0.00%> (-14.82%) ⬇️
go/consensus/tendermint/api/api.go 74.54% <0.00%> (-14.55%) ⬇️
go/worker/storage/service_external.go 40.86% <0.00%> (-6.46%) ⬇️
go/worker/keymanager/handler.go 67.92% <0.00%> (-3.78%) ⬇️
go/storage/api/grpc.go 66.88% <0.00%> (-3.68%) ⬇️
go/storage/mkvs/prefetch.go 59.32% <0.00%> (-3.39%) ⬇️
go/worker/storage/committee/node.go 69.97% <0.00%> (-3.17%) ⬇️
go/worker/compute/executor/committee/node.go 61.03% <0.00%> (-1.92%) ⬇️
go/storage/mkvs/checkpoint/checkpointer.go 63.70% <0.00%> (-1.49%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce6ec47...da790a1. Read the comment docs.

@ptrus ptrus merged commit aa5a865 into master Jun 10, 2020
@ptrus ptrus deleted the ptrus/fix/queries-workload branch June 10, 2020 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants