go/oasis-node/cmd/stake: Make list command's verbose output consistent #3016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjanez
added
c:breaking/consensus
tjanez
requested review from
kostko,
peterjgilbert,
pro-wh and
Yawning
as code owners
kostko
approved these changes
Jun 15, 2020
tjanez
force-pushed
the
tjanez/stake-cli-make-list-verbose-consistent
branch
2 times, most recently
from
9bfa05d
to
18b14e6
Compare
tjanez
changed the base branch from
tjanez/cli-convert-entity-id-to-staking-address
to
master
tjanez
force-pushed
the
tjanez/stake-cli-make-list-verbose-consistent
branch
from
18b14e6
to
1a47abc
Compare
Change 'oasis-node stake list --verbose' CLI command's output to not list all accounts' information as a single-line JSON string but rather output each account's JSON string on a separate line. This is consistent with the verbose outputs of the 'oasis-node registry entity list' and 'oasis-node registry node list' CLI commands.
tjanez
force-pushed
the
tjanez/stake-cli-make-list-verbose-consistent
branch
from
1a47abc
to
d069a4a
Compare
Codecov Report
@@ Coverage Diff @@
## master #3016 +/- ##
==========================================
+ Coverage 68.38% 68.64% +0.25%
==========================================
Files 366 366
Lines 36037 36039 +2
==========================================
+ Hits 24644 24738 +94
+ Misses 8238 8147 -91
+ Partials 3155 3154 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
oasis-node stake list --verboseCLI command's output to not list all accounts' information as a single-line JSON string but rather output each account's JSON string on a separate line.This is consistent with the verbose outputs of the
oasis-node registry entity listandoasis-node registry node listCLI commands.