runtime/committee/client: reduce gRPC max backoff timeout #3035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
requested review from
kostko,
peterjgilbert,
pro-wh and
Yawning
as code owners
Yawning
approved these changes
Jun 19, 2020
Codecov Report
@@ Coverage Diff @@
## master #3035 +/- ##
==========================================
+ Coverage 68.33% 68.39% +0.06%
==========================================
Files 367 367
Lines 36230 36238 +8
==========================================
+ Hits 24757 24785 +28
+ Misses 8282 8258 -24
- Partials 3191 3195 +4
Continue to review full report at Codecov.
|
ptrus
force-pushed
the
ptrus/fix/grpc-backoff-timeout
branch
from
b7e67a1
to
4c6754b
Compare
ptrus
force-pushed
the
ptrus/fix/grpc-backoff-timeout
branch
from
4c6754b
to
ded2c6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces the gRPC backoff MaxDelay in committee client. Committee nodes are expected to be available and this timeout is more in line with timeouts we use in the clients using these connections (e.g. storage client retries for 15 secs).
This was causing spurious
runtime_dynamicE2E test failures, where the nodes are restarted in the test. In case the storage node restart took to long, the connection retry delay got greater than the retry timeout in storage client, causing failures.