Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction status via RPC #3047

Closed
Messer4 opened this issue Jun 24, 2020 · 2 comments · Fixed by #3073
Closed

Transaction status via RPC #3047

Messer4 opened this issue Jun 24, 2020 · 2 comments · Fixed by #3073
Assignees
Labels
c:client Category: client interface c:consensus/tendermint Category: Tendermint-based consensus

Comments

@Messer4
Copy link

Messer4 commented Jun 24, 2020

SUMMARY

When extracting data from the chain GetTransactions RPC doesnt return Tx status and some data aggregations based on failed txs can be false.
It would be awesome to have Tx Status included in Tx struct.

ISSUE TYPE
  • Feature Idea
COMPONENT NAME

GetTransactions RPC method

ADDITIONAL INFORMATION
@kostko kostko added c:client Category: client interface c:consensus/tendermint Category: Tendermint-based consensus labels Jun 25, 2020
@kostko
Copy link
Member

kostko commented Jun 25, 2020

Thanks for the feature suggestion, it seems like a generally useful thing to introduce something like a GetTransactionResults that takes a height and returns execution results for all transactions in a given height. Alternatively we could also have something like GetTransactionsWithResults to reduce the number of round trips required.

@Messer4
Copy link
Author

Messer4 commented Jun 25, 2020

Second one could be more useful because reduce number of requests by RPC and increase speed of data processing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:client Category: client interface c:consensus/tendermint Category: Tendermint-based consensus
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants