go/tests/sentry: Add access control sanity checks #3062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
force-pushed
the
ptrus/fix/sentry-e2e-sc
branch
2 times, most recently
from
300777b
to
6a6432d
Compare
ptrus
commented
Jun 29, 2020
| @@ -734,10 +733,6 @@ func (net *Network) startOasisNode( | |||
| args = append(args, baseArgs...) | |||
| args = append(args, extraArgs.vec...) | |||
|
|
|||
| if !strings.HasPrefix(node.Name, "sentry-") && !strings.HasPrefix(node.Name, "ias-proxy") && len(net.byzantine) == 0 { | |||
There was a problem hiding this comment.
So i'm not sure if the && len(net.byzantine) == 0 flag was needed before, since in the new code i also enable cert rotation in byzantine tests and tests don't fail
Codecov Report
@@ Coverage Diff @@
## master #3062 +/- ##
==========================================
+ Coverage 68.16% 68.18% +0.02%
==========================================
Files 372 372
Lines 36487 36487
==========================================
+ Hits 24870 24878 +8
- Misses 8398 8400 +2
+ Partials 3219 3209 -10
Continue to review full report at Codecov.
|
ptrus
requested review from
kostko,
peterjgilbert,
pro-wh and
Yawning
as code owners
kostko
reviewed
Jun 29, 2020
ptrus
force-pushed
the
ptrus/fix/sentry-e2e-sc
branch
4 times, most recently
from
dd347fc
to
400740d
Compare
kostko
approved these changes
Jun 30, 2020
ptrus
force-pushed
the
ptrus/fix/sentry-e2e-sc
branch
from
400740d
to
8ccfb84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.