Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/registry/api: Add GetNodeByConsensusAddress method #3067

Merged
merged 2 commits into from
Jul 1, 2020

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Jun 30, 2020

Fixes: #2961

@ptrus ptrus force-pushed the ptrus/feature/node-by-consensusid branch 2 times, most recently from 621d320 to eb34c9c Compare June 30, 2020 12:12
@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #3067 into master will decrease coverage by 0.07%.
The diff coverage is 61.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3067      +/-   ##
==========================================
- Coverage   68.24%   68.17%   -0.08%     
==========================================
  Files         371      371              
  Lines       36466    36479      +13     
==========================================
- Hits        24887    24869      -18     
- Misses       8373     8404      +31     
  Partials     3206     3206              
Impacted Files Coverage Δ
go/registry/api/api.go 41.65% <ø> (ø)
go/registry/api/grpc.go 33.33% <0.00%> (-1.84%) ⬇️
go/worker/common/p2p/peermgmt.go 76.11% <0.00%> (ø)
go/consensus/tendermint/registry/registry.go 69.26% <60.00%> (+0.36%) ⬆️
go/consensus/tendermint/apps/registry/query.go 81.81% <100.00%> (+0.86%) ⬆️
go/registry/tests/tester.go 91.75% <100.00%> (+0.07%) ⬆️
go/worker/compute/executor/committee/state.go 74.07% <0.00%> (-11.12%) ⬇️
...nsensus/tendermint/apps/keymanager/transactions.go 44.11% <0.00%> (-5.89%) ⬇️
go/common/grpc/proxy/proxy.go 67.82% <0.00%> (-5.22%) ⬇️
go/worker/compute/executor/committee/node.go 61.35% <0.00%> (-4.88%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3fba70...0ab4df6. Read the comment docs.

@ptrus ptrus force-pushed the ptrus/feature/node-by-consensusid branch 4 times, most recently from 96ea2bd to dbfaa24 Compare July 1, 2020 06:03
.changelog/2961.feature.md Outdated Show resolved Hide resolved
.changelog/2961.feature.md Outdated Show resolved Hide resolved
.changelog/3067.feature.md Outdated Show resolved Hide resolved
go/consensus/tendermint/apps/registry/query.go Outdated Show resolved Hide resolved
.changelog/2961.feature.md Outdated Show resolved Hide resolved
@ptrus ptrus force-pushed the ptrus/feature/node-by-consensusid branch 2 times, most recently from 38e2abe to 65a8632 Compare July 1, 2020 07:52
@ptrus ptrus changed the title go/registry/api: Add GetNodeByConesnusID method go/registry/api: Add GetNodeByConesnusAddress method Jul 1, 2020
@ptrus ptrus force-pushed the ptrus/feature/node-by-consensusid branch from 65a8632 to 95a050e Compare July 1, 2020 07:53
@ptrus ptrus changed the title go/registry/api: Add GetNodeByConesnusAddress method go/registry/api: Add GetNodeByConsensusAddress method Jul 1, 2020
@ptrus ptrus force-pushed the ptrus/feature/node-by-consensusid branch 2 times, most recently from 21f828a to 1b72902 Compare July 1, 2020 08:17
Comment on lines 199 to 200
// GetNodeByConsensusAddress returns the Node by Consensus address at the
// specified block height.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// GetNodeByConsensusAddress returns the Node by Consensus address at the
// specified block height.
// GetNodeByConsensusAddress looks up a node by its consensus address at the
// specified block height. The nature and format of the consensus address depends
// on the specific consensus backend implementation used.

@ptrus ptrus force-pushed the ptrus/feature/node-by-consensusid branch from 1b72902 to 0ab4df6 Compare July 1, 2020 10:17
@ptrus ptrus merged commit 1dc4d46 into master Jul 1, 2020
@ptrus ptrus deleted the ptrus/feature/node-by-consensusid branch July 1, 2020 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Registry query for nodes by consensus address
2 participants