-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement PrettyPrinter for various staking types and use it in stake CLI #3087
Conversation
what do you think about this: annotate "Balance" field as "Balance (base units)" |
I think the next step will be to actually support proper units based on the genesis document (#3061). This will probably require some additional context information for the pretty printer. But maybe |
Yes. Currently, the code base doesn't distinguish between tokens and base units. Everything is a token at the moment. After #3061, I will augment the pretty printers to be able to print the balance in token units or base units.
Agreed. |
443d8e5
to
82d3f19
Compare
82d3f19
to
1c6307c
Compare
Update stake-cli E2E scenario to work with the new account info CLI command output.
1c6307c
to
ffe4281
Compare
Codecov Report
@@ Coverage Diff @@
## master #3087 +/- ##
==========================================
- Coverage 68.48% 68.19% -0.30%
==========================================
Files 372 372
Lines 36734 36814 +80
==========================================
- Hits 25156 25104 -52
- Misses 8346 8465 +119
- Partials 3232 3245 +13
Continue to review full report at Codecov.
|
Example of previous
oasis-node stake account info
CLI command output:Example of the new
oasis-node stake account info
CLI command output:TODO:
e2e/stake-cli
scenario.