go/consensus/tendermint: Refactor internal event handling #3091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostko
force-pushed
the
kostko/feature/tm-events-refactor
branch
5 times, most recently
from
908dfae
to
cff510a
Compare
Codecov Report
@@ Coverage Diff @@
## master #3091 +/- ##
==========================================
+ Coverage 68.32% 68.53% +0.20%
==========================================
Files 372 374 +2
Lines 36882 36896 +14
==========================================
+ Hits 25200 25287 +87
+ Misses 8433 8395 -38
+ Partials 3249 3214 -35
Continue to review full report at Codecov.
|
kostko
force-pushed
the
kostko/feature/tm-events-refactor
branch
from
cff510a
to
2cd8401
Compare
kostko
force-pushed
the
kostko/feature/tm-events-refactor
branch
2 times, most recently
from
1cc84bf
to
68aaf8c
Compare
Yawning
approved these changes
Jul 13, 2020
kostko
force-pushed
the
kostko/feature/tm-events-refactor
branch
13 times, most recently
from
54c9416
to
b99419c
Compare
Previously each consensus service client implemented its own event processing loop. All service clients now have a unified event loop implementation (each still runs in its own goroutine) that takes care of query subscriptions and event dispatch.
The previous implementation did not support querying for historic blocks and this adds a simple (non-optimal) implementation. Since this mock epochtime is only used in tests this seems fine.
In case the minimum write replication factor is set by the runtime, it doesn't make sense to emit partial receipts as other nodes will not accept them.
Configure the runtime to allow a smaller replication factor as otherwise execution may fail when the bad node is in the storage committee.
kostko
force-pushed
the
kostko/feature/tm-events-refactor
branch
from
b99419c
to
cebc3fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO