Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/backends: return pointers in GetEvents methods #3092

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Jul 9, 2020

No description provided.

@ptrus ptrus force-pushed the ptrus/fix/queries-workload-events-check branch from 415efab to 39bc06a Compare July 9, 2020 10:07
@ptrus ptrus changed the title conensus/tendermint/GetTxWithEvents: fix returned events go/backends: return pointers in GetEvents methods Jul 9, 2020
@ptrus ptrus force-pushed the ptrus/fix/queries-workload-events-check branch from 39bc06a to 7c8bf01 Compare July 9, 2020 10:11
To avoid unnecessary copying and to make the methods more unified with rest of
the APIs, return pointers to events in backend GetEvents methods.
@ptrus ptrus force-pushed the ptrus/fix/queries-workload-events-check branch from 7c8bf01 to 905a1c9 Compare July 9, 2020 10:18
@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #3092 into master will decrease coverage by 0.05%.
The diff coverage is 78.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3092      +/-   ##
==========================================
- Coverage   68.48%   68.43%   -0.06%     
==========================================
  Files         372      372              
  Lines       36734    36812      +78     
==========================================
+ Hits        25156    25191      +35     
- Misses       8346     8376      +30     
- Partials     3232     3245      +13     
Impacted Files Coverage Δ
go/consensus/tendermint/tendermint.go 65.13% <0.00%> (-0.44%) ⬇️
go/registry/api/api.go 41.65% <ø> (ø)
go/roothash/api/api.go 75.00% <ø> (ø)
go/staking/api/api.go 72.72% <68.00%> (-1.40%) ⬇️
go/staking/api/commission.go 95.58% <80.64%> (-3.09%) ⬇️
go/consensus/tendermint/registry/registry.go 76.11% <100.00%> (ø)
go/consensus/tendermint/roothash/roothash.go 64.02% <100.00%> (+2.33%) ⬆️
go/consensus/tendermint/staking/staking.go 68.63% <100.00%> (ø)
go/oasis-node/cmd/stake/account.go 57.21% <100.00%> (-0.23%) ⬇️
go/registry/api/grpc.go 36.08% <100.00%> (ø)
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7da6fb9...905a1c9. Read the comment docs.

@ptrus ptrus merged commit 492a1d6 into master Jul 9, 2020
@ptrus ptrus deleted the ptrus/fix/queries-workload-events-check branch July 9, 2020 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants