Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill tests/fixture-data with fire #3110

Closed
Yawning opened this issue Jul 16, 2020 · 0 comments · Fixed by #3135
Closed

Kill tests/fixture-data with fire #3110

Yawning opened this issue Jul 16, 2020 · 0 comments · Fixed by #3135
Labels
c:bug Category: bug c:testing Category: testing

Comments

@Yawning
Copy link
Contributor

Yawning commented Jul 16, 2020

JSON documents with account addresses that come from god only knows where is a monumental pain in the ass to maintain.

As cute as the idea is, we should probably just hard code the documents into the relevant test cases so we can do things like "Automatically derive the addresses from public keys", so that the next victim that has to update these things en-mass isn't stuck trying to figure out where they came from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:bug Category: bug c:testing Category: testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant