Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GOVERNANCE.md #3130

Merged
merged 1 commit into from
Jul 29, 2020
Merged

Add GOVERNANCE.md #3130

merged 1 commit into from
Jul 29, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Jul 27, 2020

No description provided.

@kostko kostko added the c:docs Category: documentation label Jul 27, 2020
@kostko kostko requested a review from a team July 27, 2020 05:07
@kostko
Copy link
Member Author

kostko commented Jul 27, 2020 •
edited

@Afauvre commented in c04f8f5#commitcomment-40922183:

Can we call this "Proposed Contribution Guidelines" instead of Governance? I think Governance has a different meaning that focuses a bit more on voting by the community and notes about how stake influences voting power, etc.

Sure, we can do that. I've updated the title to be "Project Contribution Guidelines". Should it still be located in a GOVERNANCE.md file (as mentioned here)?

@kostko
Copy link
Member Author

kostko commented Jul 27, 2020

Hm, the updated title does seem too similar with what is in CONTRIBUTING.md which contains actual ways to contribute, not the governance process.

ptrus
ptrus reviewed Jul 27, 2020
View reviewed changes
GOVERNANCE.md Outdated Show resolved Hide resolved
tjanez
tjanez reviewed Jul 27, 2020
View reviewed changes
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated
@@ -0,0 +1,98 @@
# Project Contribution Guidelines
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... shouldn't this be "Governance" or something similar?

Contributing Guidelines is in CONTRIBUTING.md...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was like that before, see comment by @Afauvre and my reply above.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it back to "Governance Model".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, I didn't read that before.

I think "Governance Model" and GOVERNANCE.md is fine since this governs how the Oasis Core project is run.

Of course, there is the governance of the Oasis Network but that should be described in a different place, probably a document in https://github.com/oasisprotocol/docs.

GOVERNANCE.md Show resolved Hide resolved
@kostko kostko force-pushed the kostko/docs/governance branch 2 times, most recently from 1cd3e17 to 101dca4 Compare July 27, 2020 11:16
tjanez
tjanez approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@tjanez tjanez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, looks good!

GOVERNANCE.md Outdated Show resolved Hide resolved
@kostko kostko marked this pull request as ready for review July 28, 2020 08:31
pro-wh
pro-wh approved these changes Jul 28, 2020
View reviewed changes
GOVERNANCE.md Outdated Show resolved Hide resolved
GOVERNANCE.md Outdated Show resolved Hide resolved
@kostko kostko merged commit 7ab5ad2 into master Jul 29, 2020
@kostko kostko deleted the kostko/docs/governance branch July 29, 2020 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjanez tjanez tjanez approved these changes

@abukosek abukosek abukosek approved these changes

@Yawning Yawning Yawning approved these changes

@ptrus ptrus ptrus approved these changes

@jberci jberci jberci approved these changes

@pro-wh pro-wh pro-wh approved these changes

@peterjgilbert peterjgilbert Awaiting requested review from peterjgilbert peterjgilbert is a code owner

Assignees
No one assigned
Labels
c:docs Category: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@kostko @tjanez @abukosek @Yawning @ptrus @jberci @pro-wh