Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/common/prettyprint: Rename FractionBase10() to QuantityFrac() #3131

Merged
merged 1 commit into from
Jul 27, 2020

Conversation

tjanez
Copy link
Member

@tjanez tjanez commented Jul 27, 2020

I think it is a better name for this function as it more clearly captures the specific relation to Quantity type.

Follow up from: #3129 (comment).

I think it is a better name for this function as it more clearly
captures the specific relation to Quantity type.
@codecov
Copy link

codecov bot commented Jul 27, 2020

Codecov Report

Merging #3131 into master will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3131      +/-   ##
==========================================
- Coverage   69.00%   68.92%   -0.09%     
==========================================
  Files         374      374              
  Lines       37000    37000              
==========================================
- Hits        25532    25502      -30     
- Misses       8232     8251      +19     
- Partials     3236     3247      +11     
Impacted Files Coverage Δ
go/common/prettyprint/quantity.go 100.00% <100.00%> (ø)
go/staking/api/prettyprint.go 100.00% <100.00%> (ø)
go/worker/compute/executor/committee/fault.go 68.96% <0.00%> (-8.05%) ⬇️
go/storage/api/root_cache.go 72.41% <0.00%> (-6.90%) ⬇️
go/worker/storage/service_external.go 47.31% <0.00%> (-6.46%) ⬇️
go/runtime/tagindexer/tagindexer.go 68.47% <0.00%> (-4.35%) ⬇️
go/runtime/host/sandbox/sandbox.go 67.28% <0.00%> (-4.09%) ⬇️
go/consensus/tendermint/services.go 78.90% <0.00%> (-3.91%) ⬇️
go/storage/mkvs/tree.go 89.28% <0.00%> (-3.58%) ⬇️
go/runtime/host/protocol/connection.go 62.16% <0.00%> (-3.48%) ⬇️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24bcb82...450023c. Read the comment docs.

Copy link
Contributor

@Yawning Yawning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok sure.

@tjanez tjanez merged commit 5464ad3 into master Jul 27, 2020
@tjanez tjanez deleted the tjanez/prettier-rename-quantity-frac branch July 27, 2020 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants