Display (unsigned) transaction's pretty print on the terminal before signing #3137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjanez
force-pushed
the
tjanez/cli-txn-sign-confirm
branch
2 times, most recently
from
a00e174
to
0fb5edd
Compare
tjanez
requested review from
kostko,
peterjgilbert,
pro-wh and
Yawning
as code owners
Codecov Report
@@ Coverage Diff @@
## master #3137 +/- ##
==========================================
+ Coverage 68.76% 68.97% +0.20%
==========================================
Files 376 376
Lines 37079 37115 +36
==========================================
+ Hits 25498 25600 +102
+ Misses 8317 8259 -58
+ Partials 3264 3256 -8
Continue to review full report at Codecov.
|
kostko
approved these changes
Jul 29, 2020
This will allow passing additional information to SignAndSaveTx().
Adapt 'oasis-node stake account gen_*' CLI commands to display stake amount in pretty printed transactions in token values.
If file signer is used, ask for confirmation before signing a
transaction, unless --assume_yes flag is set.
go/oasis-node/cmd/{keymanager,registry/entity,registry/runtime,stake}:
Add support for --assume_yes flag.
go/oasis-test-runner/{oasis/cli,scenario/e2e}: Set --assume_yes flag for
all commands that sign transactions.
tjanez
force-pushed
the
tjanez/cli-txn-sign-confirm
branch
from
0fb5edd
to
c3c78db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3134.