go/oasis-node: Fix the interactive prompt to be correct #3143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yawning
force-pushed
the
yawning/fix/isatty
branch
from
2d3d610
to
2e908ab
Compare
kostko
reviewed
Jul 30, 2020
Having to use a command line flag when not running in an interactive terminal is somewhat silly, and recursively calling the Fisher Price Baby's First Interactive Prompt routine till the command exhauses the heap and crashes when not run in a tty is even sillier.
Since the sub-commands ran from the test harness will always have stdin tied to `/dev/null`, this is now implicit.
kostko
approved these changes
Jul 30, 2020
Yawning
force-pushed
the
yawning/fix/isatty
branch
from
2e908ab
to
54fadb0
Compare
tjanez
approved these changes
Jul 30, 2020
Codecov Report
@@ Coverage Diff @@
## master #3143 +/- ##
==========================================
+ Coverage 68.57% 68.93% +0.35%
==========================================
Files 376 377 +1
Lines 37115 37130 +15
==========================================
+ Hits 25453 25595 +142
+ Misses 8402 8271 -131
- Partials 3260 3264 +4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--assume_yesif not running in a tty