Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/oasis-node/cmd/common: Smaller signer-related improvements #3149

Merged
merged 2 commits into from
Jul 31, 2020
Merged

go/oasis-node/cmd/common: Smaller signer-related improvements #3149

merged 2 commits into from
Jul 31, 2020

Conversation

tjanez
Copy link
Member

@tjanez tjanez commented Jul 30, 2020

No description provided.

@tjanez tjanez added the c:cli Category: command line interface label Jul 30, 2020
@tjanez tjanez mentioned this pull request Jul 30, 2020
Merged
@codecov
Copy link

codecov bot commented Jul 30, 2020 •
edited

Codecov Report

Merging #3149 into master will decrease coverage by 0.31%.
The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3149      +/-   ##
==========================================
- Coverage   68.89%   68.58%   -0.32%     
==========================================
  Files         383      383              
  Lines       37374    37379       +5     
==========================================
- Hits        25750    25636     -114     
- Misses       8345     8468     +123     
+ Partials     3279     3275       -4
Impacted Files Coverage Δ
go/oasis-node/cmd/common/consensus/consensus.go 42.39% <37.50%> (-0.14%) ⬇️
go/oasis-node/cmd/common/signer/signer.go 57.14% <100.00%> (ø)
go/storage/metrics.go 78.26% <0.00%> (-13.05%) ⬇️
go/consensus/tendermint/apps/scheduler/query.go 71.05% <0.00%> (-7.90%) ⬇️
go/consensus/tendermint/epochtime/epochtime.go 78.78% <0.00%> (-7.58%) ⬇️
go/registry/api/grpc.go 36.08% <0.00%> (-7.34%) ⬇️
go/consensus/tendermint/apps/staking/query.go 49.09% <0.00%> (-7.28%) ⬇️
go/storage/api/root_cache.go 70.11% <0.00%> (-4.60%) ⬇️
go/storage/client/client.go 72.50% <0.00%> (-4.59%) ⬇️
go/consensus/tendermint/abci/mux.go 68.89% <0.00%> (-4.38%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3be2b46...d3ac3f0. Read the comment docs.

@tjanez
go/oasis-node/cmd/common/consensus: Print helper text about txn review
fa213e7 
If one uses the signer plugin and a TTY, print a helper text to notify
him that he may need to review the transaction on the device if a
hardware-based signer plugin is used.
@tjanez
go/oasis-node/cmd/common/signer: Remove ledger in signer flag's help
d3ac3f0 
It is no longer supported directly.
@tjanez tjanez force-pushed the tjanez/small-ledger-fixes branch from c617642 to d3ac3f0 Compare July 31, 2020 07:58
@tjanez tjanez merged commit bb17ffd into master Jul 31, 2020
@tjanez tjanez deleted the tjanez/small-ledger-fixes branch July 31, 2020 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kostko kostko kostko approved these changes

@peterjgilbert peterjgilbert Awaiting requested review from peterjgilbert peterjgilbert is a code owner

@pro-wh pro-wh Awaiting requested review from pro-wh pro-wh is a code owner

@Yawning Yawning Awaiting requested review from Yawning

Assignees
No one assigned
Labels
c:cli Category: command line interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tjanez @kostko