Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/worker/keymanager: Ignore runtimes not in policy document #3162

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Aug 3, 2020

Fixes:

Maybe it would be better to make sure that the key manager worker (not only the enclave) ignores any runtimes which are not in the policy document but are trying to use the key manager? This would make the key manager reject requests one layer earlier.

TODO:

  • potentially also implement stopping clientRuntimeWatchers for runtimes that were removed from policy docs
    • can do in future if needed

@ptrus ptrus force-pushed the ptrus/feature/km-ignore-runtimes branch 5 times, most recently from 9cc2333 to 373c220 Compare August 3, 2020 17:58
@codecov
Copy link

codecov bot commented Aug 3, 2020

Codecov Report

Merging #3162 into master will increase coverage by 0.43%.
The diff coverage is 52.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3162      +/-   ##
==========================================
+ Coverage   68.27%   68.70%   +0.43%     
==========================================
  Files         385      385              
  Lines       37890    37945      +55     
==========================================
+ Hits        25869    26072     +203     
+ Misses       8731     8552     -179     
- Partials     3290     3321      +31     
Impacted Files Coverage Δ
go/worker/keymanager/worker.go 63.82% <52.68%> (-3.35%) ⬇️
go/worker/compute/executor/committee/state.go 85.18% <0.00%> (-14.82%) ⬇️
go/runtime/host/sandbox/sandbox.go 67.28% <0.00%> (-10.04%) ⬇️
...ompute/txnscheduler/algorithm/batching/batching.go 78.66% <0.00%> (-6.67%) ⬇️
go/consensus/tendermint/api/timer.go 67.00% <0.00%> (-5.00%) ⬇️
go/worker/common/committee/runtime_host.go 65.71% <0.00%> (-4.77%) ⬇️
go/storage/mkvs/remove.go 85.85% <0.00%> (-4.05%) ⬇️
go/worker/compute/txnscheduler/committee/node.go 61.26% <0.00%> (-3.61%) ⬇️
go/consensus/tendermint/full/services.go 80.46% <0.00%> (-2.35%) ⬇️
go/runtime/host/protocol/connection.go 62.16% <0.00%> (-1.94%) ⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e147b73...45fdfa1. Read the comment docs.

@ptrus ptrus force-pushed the ptrus/feature/km-ignore-runtimes branch from 373c220 to 37479c7 Compare August 4, 2020 08:11
@ptrus ptrus marked this pull request as ready for review August 4, 2020 08:33
go/worker/keymanager/worker.go Outdated Show resolved Hide resolved
go/worker/keymanager/worker.go Outdated Show resolved Hide resolved
go/worker/keymanager/worker.go Outdated Show resolved Hide resolved
@ptrus ptrus force-pushed the ptrus/feature/km-ignore-runtimes branch from 37479c7 to a3a77b3 Compare August 4, 2020 14:45
@ptrus ptrus force-pushed the ptrus/feature/km-ignore-runtimes branch from a3a77b3 to d6221ad Compare August 5, 2020 08:18
@ptrus ptrus force-pushed the ptrus/feature/km-ignore-runtimes branch from d6221ad to 45fdfa1 Compare August 5, 2020 09:53
@ptrus ptrus merged commit 6b66402 into master Aug 5, 2020
@ptrus ptrus deleted the ptrus/feature/km-ignore-runtimes branch August 5, 2020 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants