Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: Use separate cache for checking transactions #3191

Merged
merged 1 commit into from
Aug 17, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Aug 14, 2020

This allows calling both check and execute methods against the same runtime
instance.

@kostko kostko requested a review from ptrus August 14, 2020 20:19
This allows calling both check and execute methods against the same runtime
instance.
@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #3191 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3191      +/-   ##
==========================================
- Coverage   68.06%   68.05%   -0.02%     
==========================================
  Files         380      380              
  Lines       36620    36620              
==========================================
- Hits        24925    24920       -5     
  Misses       8480     8480              
- Partials     3215     3220       +5     
Impacted Files Coverage Δ
go/worker/common/p2p/dispatch.go 67.28% <0.00%> (-7.48%) ⬇️
go/common/grpc/policy/policy.go 64.38% <0.00%> (-6.85%) ⬇️
go/consensus/tendermint/full/services.go 82.81% <0.00%> (-5.47%) ⬇️
go/storage/metrics.go 81.08% <0.00%> (-4.06%) ⬇️
go/common/sgx/common.go 68.68% <0.00%> (-4.05%) ⬇️
.../consensus/tendermint/apps/roothash/state/state.go 68.62% <0.00%> (-3.93%) ⬇️
go/worker/keymanager/handler.go 60.37% <0.00%> (-3.78%) ⬇️
go/storage/api/root_cache.go 77.77% <0.00%> (-3.18%) ⬇️
go/worker/storage/service_external.go 57.35% <0.00%> (-2.95%) ⬇️
...consensus/tendermint/apps/roothash/transactions.go 59.45% <0.00%> (-2.71%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08adabe...3d0a0c8. Read the comment docs.

Copy link
Member

@ptrus ptrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work, thanks!

@kostko kostko marked this pull request as ready for review August 16, 2020 17:51
@kostko kostko merged commit 81a177f into master Aug 17, 2020
@kostko kostko deleted the kostko/fix/rt-cache-check branch August 17, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants