Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/common/cbor: Bump fxamacker/cbor to 58b1cf4afc2b #3204

Merged
merged 1 commit into from
Aug 20, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Aug 19, 2020

This should result in some smaller payloads as omitempty should work better for
our use cases now.

@kostko kostko force-pushed the kostko/feature/bump-cbor-pr243 branch 2 times, most recently from 90d4c82 to 660c9e3 Compare August 20, 2020 08:39
@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #3204 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3204      +/-   ##
==========================================
+ Coverage   67.43%   67.49%   +0.06%     
==========================================
  Files         380      380              
  Lines       36474    36474              
==========================================
+ Hits        24597    24619      +22     
+ Misses       8718     8701      -17     
+ Partials     3159     3154       -5     
Impacted Files Coverage Δ
go/common/cbor/versioned.go 64.70% <100.00%> (ø)
go/oasis-node/cmd/common/metrics/disk.go 65.51% <0.00%> (-20.69%) ⬇️
go/oasis-node/cmd/common/metrics/resource.go 84.00% <0.00%> (-8.00%) ⬇️
go/worker/common/p2p/dispatch.go 67.28% <0.00%> (-7.48%) ⬇️
...n/crypto/signature/signers/memory/memory_signer.go 71.42% <0.00%> (-4.77%) ⬇️
go/storage/metrics.go 81.08% <0.00%> (-4.06%) ⬇️
go/runtime/host/protocol/connection.go 62.16% <0.00%> (-3.87%) ⬇️
go/worker/keymanager/handler.go 60.37% <0.00%> (-3.78%) ⬇️
go/storage/mkvs/tree.go 89.28% <0.00%> (-3.58%) ⬇️
go/worker/compute/executor/committee/node.go 65.00% <0.00%> (-3.00%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa2c613...960df21. Read the comment docs.

@kostko kostko force-pushed the kostko/feature/bump-cbor-pr243 branch from 660c9e3 to 52beeb7 Compare August 20, 2020 08:57
This should result in some smaller payloads as omitempty should work better for
our use cases now.
@kostko kostko force-pushed the kostko/feature/bump-cbor-pr243 branch from 52beeb7 to 960df21 Compare August 20, 2020 09:21
@kostko kostko marked this pull request as ready for review August 20, 2020 10:14
@kostko kostko added the c:breaking/consensus Category: breaking consensus changes label Aug 20, 2020
@kostko kostko merged commit 2667194 into master Aug 20, 2020
@kostko kostko deleted the kostko/feature/bump-cbor-pr243 branch August 20, 2020 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:breaking/consensus Category: breaking consensus changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants