Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/runtime/client: Fix possible panic on shutdown #3271

Merged
merged 1 commit into from
Sep 14, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Sep 14, 2020

No description provided.

@kostko kostko added c:client Category: client interface c:runtime Category: runtime c:bug Category: bug labels Sep 14, 2020
@kostko kostko force-pushed the kostko/fix/rt-client-shutdown branch from 98ebdfa to 72d96a5 Compare September 14, 2020 09:17
@kostko kostko requested a review from ptrus September 14, 2020 09:17
@kostko kostko force-pushed the kostko/fix/rt-client-shutdown branch 2 times, most recently from d14674b to f035093 Compare September 14, 2020 09:38
@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #3271 into master will increase coverage by 0.11%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3271      +/-   ##
==========================================
+ Coverage   67.73%   67.85%   +0.11%     
==========================================
  Files         371      371              
  Lines       36884    36889       +5     
==========================================
+ Hits        24984    25031      +47     
+ Misses       8712     8670      -42     
  Partials     3188     3188              
Impacted Files Coverage Δ
go/runtime/client/client.go 69.19% <30.76%> (-1.80%) ⬇️
go/runtime/client/watcher.go 70.54% <50.00%> (-0.23%) ⬇️
go/storage/mkvs/checkpoint/restorer.go 82.45% <0.00%> (-10.53%) ⬇️
go/oasis-node/cmd/common/metrics/resource.go 84.00% <0.00%> (-8.00%) ⬇️
go/consensus/tendermint/abci/state/state.go 61.53% <0.00%> (-7.70%) ⬇️
go/common/grpc/policy/policy.go 64.38% <0.00%> (-6.85%) ⬇️
go/worker/storage/committee/checkpoint_sync.go 74.55% <0.00%> (-6.10%) ⬇️
go/storage/mkvs/syncer/proof.go 83.92% <0.00%> (-3.58%) ⬇️
go/storage/client/client.go 71.68% <0.00%> (-2.22%) ⬇️
go/worker/compute/executor/committee/node.go 64.83% <0.00%> (-1.38%) ⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 570e3ad...1d217af. Read the comment docs.

@kostko kostko force-pushed the kostko/fix/rt-client-shutdown branch from f035093 to d98e169 Compare September 14, 2020 11:14
@kostko kostko force-pushed the kostko/fix/rt-client-shutdown branch from d98e169 to 1d217af Compare September 14, 2020 13:10
@kostko kostko merged commit c200555 into master Sep 14, 2020
@kostko kostko deleted the kostko/fix/rt-client-shutdown branch September 14, 2020 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:bug Category: bug c:client Category: client interface c:runtime Category: runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants