Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use hash-based message ids for P2P messages #3275

Closed
kostko opened this issue Sep 14, 2020 · 0 comments · Fixed by #3280
Closed

Use hash-based message ids for P2P messages #3275

kostko opened this issue Sep 14, 2020 · 0 comments · Fixed by #3280
Assignees
@ptrus
Labels
c:p2p Category: P2P

Comments

@kostko
Copy link
Member

kostko commented Sep 14, 2020 •
edited

Currently we use the default message ids in libp2p pubsub, which defaults to source + sequence number. We should instead change it to be the hash of the payload. This can be configured by using pubsub.WithMessageIdFn.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptrus ptrus

Labels
c:p2p Category: P2P
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

go/worker/p2p: Use hash of the message payload as message ID oasisprotocol/oasis-core
2 participants
@kostko @ptrus