go/ci: update nancy #3283
Merged
go/ci: update nancy #3283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
force-pushed
the
ptrus/feature/update-nancy
branch
2 times, most recently
from
e61e761
to
1dbdf0c
Compare
Codecov Report
@@ Coverage Diff @@
## master #3283 +/- ##
==========================================
- Coverage 67.90% 67.89% -0.01%
==========================================
Files 371 371
Lines 36888 36888
==========================================
- Hits 25047 25046 -1
+ Misses 8660 8652 -8
- Partials 3181 3190 +9
Continue to review full report at Codecov.
|
ptrus
requested review from
kostko,
peterjgilbert,
pro-wh and
Yawning
as code owners
ptrus
commented
Sep 17, 2020
| # upstream tendermint depends on websocket@1.4.0. We force a fixed version of | ||
| # the websocket in go.mod: https://github.com/oasisprotocol/oasis-core/issues/2931 | ||
| # https://ossindex.sonatype.org/vuln/5f259e63-3efb-4c47-b593-d175dca716b0 | ||
| 5f259e63-3efb-4c47-b593-d175dca716b0 |
There was a problem hiding this comment.
go list -json -m all (the new way to use nancy with go modules) only lists websocket@1.4.0 so this isnt needed anymore,
kostko
approved these changes
Sep 17, 2020
kostko
reviewed
Sep 17, 2020
.changelog/3283.internal.md
Outdated
| @@ -0,0 +1 @@ | |||
| go/ci: Update nancy | |||
There was a problem hiding this comment.
Maybe specify to which version it has been updated.
ptrus
force-pushed
the
ptrus/feature/update-nancy
branch
from
1dbdf0c
to
f52d25d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.