Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing the periodic retries in runtime client SubmitTx #3325

Closed
ptrus opened this issue Sep 25, 2020 · 0 comments · Fixed by #3335
Closed

Consider removing the periodic retries in runtime client SubmitTx #3325

ptrus opened this issue Sep 25, 2020 · 0 comments · Fixed by #3335
Assignees
Labels
c:p2p Category: P2P

Comments

@ptrus
Copy link
Member

ptrus commented Sep 25, 2020

Ever since starting to use hash message payloads as libp2p msg ids (#3280), the runtime client re-sending messages is ineffective:

// Check if any transactions are due for a retry.
, since when a message with same payload is re-published the libp2p client doesn't actually publish the message if has already published a msg with that id (this check is done locally before publishing messages, not on the receiving end).

Note: client also retries on epoch transitions, which results in new message payloads (groupVersion changes) which works fine.

So we can either:

  • remove the periodic client retry (retry on epoch transitions is needed and should remain)
  • update the Tx message format (or hash function) to avoid duplicate messages in this case

In any case disabling retries in E2E tests was actually a good thing as it discovers issues that can otherwise get masked by retrying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:p2p Category: P2P
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant